You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2016/12/15 15:33:57 UTC
Review Request 54784: Adds tests for authorization when attaching to a
container input.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/
-----------------------------------------------------------
Review request for mesos and Adam B.
Repository: mesos
Description
-------
Adds tests for authorization when attaching to a container input.
Diffs
-----
src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16
Diff: https://reviews.apache.org/r/54784/diff/
Testing
-------
Thanks,
Alexander Rojas
Re: Review Request 54784: Adds tests for authorization when attaching
to a container input.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/#review164581
-----------------------------------------------------------
Fix it, then Ship it!
Could you add the relevant JIRA, MESOS-6886? Also, the commit message should be in the past tense.
src/tests/api_tests.cpp (line 4313)
<https://reviews.apache.org/r/54784/#comment236362>
Could you include a comment above the test saying explicitly what we are testing here?
src/tests/api_tests.cpp (lines 4370 - 4371)
<https://reviews.apache.org/r/54784/#comment236368>
Is this comment still accurate?
- Greg Mann
On Dec. 15, 2016, 3:34 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54784/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 3:34 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds tests for authorization when attaching to a container input.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16
>
> Diff: https://reviews.apache.org/r/54784/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54784: Added authorization tests when trying to
attach to a container input.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/#review165717
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54783, 54784]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 15, 2017, 2:31 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54784/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 2:31 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6886
> https://issues.apache.org/jira/browse/MESOS-6886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces a test where a principal is allowed to launch a container
> session, but not to attach to its input, therefore its attempts should
> fail.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
>
> Diff: https://reviews.apache.org/r/54784/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54784: Added authorization tests when trying to
attach to a container input.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/#review166121
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Feb. 15, 2017, 6:31 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54784/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2017, 6:31 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-6886
> https://issues.apache.org/jira/browse/MESOS-6886
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduces a test where a principal is allowed to launch a container
> session, but not to attach to its input, therefore its attempts should
> fail.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
>
> Diff: https://reviews.apache.org/r/54784/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54784: Added authorization tests when trying to
attach to a container input.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 3:31 p.m.)
Review request for mesos and Adam B.
Summary (updated)
-----------------
Added authorization tests when trying to attach to a container input.
Bugs: MESOS-6886
https://issues.apache.org/jira/browse/MESOS-6886
Repository: mesos
Description
-------
Introduces a test where a principal is allowed to launch a container
session, but not to attach to its input, therefore its attempts should
fail.
Diffs
-----
src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
Diff: https://reviews.apache.org/r/54784/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 54784: Adds authorization tests when trying to
attach to a container input.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/
-----------------------------------------------------------
(Updated Feb. 15, 2017, 3:31 p.m.)
Review request for mesos and Adam B.
Changes
-------
Changes requested by Greg plus some changes needed to take into account recent changes in the API.
Summary (updated)
-----------------
Adds authorization tests when trying to attach to a container input.
Bugs: MESOS-6886
https://issues.apache.org/jira/browse/MESOS-6886
Repository: mesos
Description (updated)
-------
Introduces a test where a principal is allowed to launch a container
session, but not to attach to its input, therefore its attempts should
fail.
Diffs (updated)
-----
src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
Diff: https://reviews.apache.org/r/54784/diff/
Testing
-------
make check
Thanks,
Alexander Rojas
Re: Review Request 54784: Adds tests for authorization when attaching
to a container input.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/#review159366
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54783, 54784]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 15, 2016, 3:34 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54784/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2016, 3:34 p.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds tests for authorization when attaching to a container input.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16
>
> Diff: https://reviews.apache.org/r/54784/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 54784: Adds tests for authorization when attaching
to a container input.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54784/
-----------------------------------------------------------
(Updated Dec. 15, 2016, 4:34 p.m.)
Review request for mesos and Adam B.
Repository: mesos
Description
-------
Adds tests for authorization when attaching to a container input.
Diffs
-----
src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16
Diff: https://reviews.apache.org/r/54784/diff/
Testing (updated)
-------
make check
Thanks,
Alexander Rojas