You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/06 06:21:46 UTC

[GitHub] [shardingsphere] MingxingLAI commented on pull request #9967: Issue#9948 refactor TablesContext

MingxingLAI commented on pull request #9967:
URL: https://github.com/apache/shardingsphere/pull/9967#issuecomment-833259878


   > > Any suggestion or question ? @tristaZero @terrymanu
   > 
   > Hi, What is variable name `seen` mean?
   
   
   Did you notice my previous explanation ？ 
   
   The `seen` set is used for deduplication, and its function is the same as the original HashMap `tableMaps`
   
   - removeIf will remove an element if it meets the specified criteria
   - Set.add will return false if it did not modify the Set, i.e. already contains the value
   
   combining these two, it will remove all elements which has been encountered before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org