You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by GitBox <gi...@apache.org> on 2022/05/02 17:06:16 UTC

[GitHub] [jclouds] DImuthuUpe opened a new pull request, #142: Adding access key auth support for openstack V3

DImuthuUpe opened a new pull request, #142:
URL: https://github.com/apache/jclouds/pull/142

   Please refer to the discussion thread [1]
   
   [1] https://lists.apache.org/thread/2p7qc20rn19r3yhsfd63p3o3h587f7oh


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] edipdemirbilek commented on pull request #142: Adding access key auth support for openstack V3

Posted by "edipdemirbilek (via GitHub)" <gi...@apache.org>.
edipdemirbilek commented on PR #142:
URL: https://github.com/apache/jclouds/pull/142#issuecomment-1692223266

   @gaul I have run into the same issue. i wonder is this was ever fixed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul commented on pull request #142: Adding access key auth support for openstack V3

Posted by GitBox <gi...@apache.org>.
gaul commented on PR #142:
URL: https://github.com/apache/jclouds/pull/142#issuecomment-1277586595

   @DImuthuUpe Can we move forward with this or should I close it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] nacx commented on a diff in pull request #142: Adding access key auth support for openstack V3

Posted by GitBox <gi...@apache.org>.
nacx commented on code in PR #142:
URL: https://github.com/apache/jclouds/pull/142#discussion_r864274336


##########
apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v3/auth/V3AuthenticationApi.java:
##########
@@ -57,4 +60,10 @@ public interface V3AuthenticationApi extends AuthenticationApi, Closeable {
    @Override
    Token authenticateToken(TenantOrDomainAndCredentials<TokenCredentials> credentials);
 
+   @Named("token:create")
+   @POST
+   @ResponseParser(ParseTokenFromHttpResponse.class)
+   @MapBinder(BindAccessKeyAuthToJsonPayload.class)
+   @Override
+   AuthInfo authenticateAccessKey(TenantOrDomainAndCredentials<ApiAccessKeyCredentials> credentials);

Review Comment:
   Please add the corresponding unit tests here: https://github.com/apache/jclouds/blob/master/apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v3/auth/V3AuthenticationApiMockTest.java
   
   And the live test as well here: 
   https://github.com/apache/jclouds/blob/master/apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v3/auth/V3AuthenticationApiLiveTest.java
   
   And include in a comment in the PR the output of running the live tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] smarru commented on pull request #142: Adding access key auth support for openstack V3

Posted by GitBox <gi...@apache.org>.
smarru commented on PR #142:
URL: https://github.com/apache/jclouds/pull/142#issuecomment-1115144366

   @gaul drawing your attention, can you please review and provide us feedback, we would like to use this in Apache Airavata


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul commented on pull request #142: Adding access key auth support for openstack V3

Posted by "gaul (via GitHub)" <gi...@apache.org>.
gaul commented on PR #142:
URL: https://github.com/apache/jclouds/pull/142#issuecomment-1399747692

   Please re-open if this is still relevant.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [jclouds] gaul closed pull request #142: Adding access key auth support for openstack V3

Posted by "gaul (via GitHub)" <gi...@apache.org>.
gaul closed pull request #142: Adding access key auth support for openstack V3
URL: https://github.com/apache/jclouds/pull/142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@jclouds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org