You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bo wang <bo...@tcloudcomputing.com> on 2013/08/23 10:08:54 UTC
Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts screen is
in processing state forever with Delete Events/Alerts request having no
filter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13770/
-----------------------------------------------------------
Review request for cloudstack, Brian Federle and bharat kumar.
Bugs: CLOUDSTACK-3363
Repository: cloudstack-git
Description
-------
1.The loading screen won't disappear when delete the events or alerts with incorrect parameters ,Because there is no handling for exception in the js code.
2.Error messages are not completely correct, it should be "Either type or enddate must be specified".
Diffs
-----
api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java b0deaa9
api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java c5594e2
api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java 548c2f3
ui/scripts/events.js 46d45c0
Diff: https://reviews.apache.org/r/13770/diff/
Testing
-------
1.The loading screen will disappear when close the error message dialog.
2.The error message will be "Either type or enddate must be specified".
Thanks,
bo wang
Re: Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts screen
is in processing state forever with Delete Events/Alerts request having no
filter
Posted by Sanjay Tripathi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13770/#review25467
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java
<https://reviews.apache.org/r/13770/#comment49887>
The API expects either of the three parameter i.e ids, type or enddate, so throwing the message appropriatly. For now, UI is not passing more than one ids (not implemented in UI.).
So this change is not required.
api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java
<https://reviews.apache.org/r/13770/#comment49888>
This change is wrong and not required.
api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java
<https://reviews.apache.org/r/13770/#comment49889>
This change is wrong and not required.
- Sanjay Tripathi
On Aug. 23, 2013, 8:08 a.m., bo wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13770/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2013, 8:08 a.m.)
>
>
> Review request for cloudstack, Brian Federle and bharat kumar.
>
>
> Bugs: CLOUDSTACK-3363
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1.The loading screen won't disappear when delete the events or alerts with incorrect parameters ,Because there is no handling for exception in the js code.
> 2.Error messages are not completely correct, it should be "Either type or enddate must be specified".
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java b0deaa9
> api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java c5594e2
> api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java 548c2f3
> ui/scripts/events.js 46d45c0
>
> Diff: https://reviews.apache.org/r/13770/diff/
>
>
> Testing
> -------
>
> 1.The loading screen will disappear when close the error message dialog.
> 2.The error message will be "Either type or enddate must be specified".
>
>
> Thanks,
>
> bo wang
>
>
Re: Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts screen
is in processing state forever with Delete Events/Alerts request having no
filter
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13770/#review26441
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Aug. 28, 2013, 7:46 a.m., bo wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13770/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 7:46 a.m.)
>
>
> Review request for cloudstack, Brian Federle and bharat kumar.
>
>
> Bugs: CLOUDSTACK-3363
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1.The loading screen won't disappear when delete the events or alerts with incorrect parameters ,Because there is no handling for exception in the js code.
> 2.Error messages are not completely correct, it should be "Either type or enddate must be specified".
>
>
> Diffs
> -----
>
> ui/scripts/events.js 46d45c0
>
> Diff: https://reviews.apache.org/r/13770/diff/
>
>
> Testing
> -------
>
> 1.The loading screen will disappear when close the error message dialog.
> 2.The error message will be "Either type or enddate must be specified".
>
>
> Thanks,
>
> bo wang
>
>
Re: Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts screen
is in processing state forever with Delete Events/Alerts request having no
filter
Posted by Amogh Vasekar <am...@citrix.com>.
> On Sept. 27, 2013, 6:54 p.m., ASF Subversion and Git Services wrote:
> > Commit 38b94e934c38556ed3974ab16a35d5be33f4edc4 in branch refs/heads/master from brito wang
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=38b94e9 ]
> >
> > CLOUDSTACK-3363 UI > fix list Events/Alerts screen is in processing state forever with Delete Events/Alerts request having no filter
> >
Since this has been submitted, Bo can you please close the request?
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13770/#review26442
-----------------------------------------------------------
On Aug. 28, 2013, 7:46 a.m., bo wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13770/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 7:46 a.m.)
>
>
> Review request for cloudstack, Brian Federle and bharat kumar.
>
>
> Bugs: CLOUDSTACK-3363
> https://issues.apache.org/jira/browse/CLOUDSTACK-3363
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1.The loading screen won't disappear when delete the events or alerts with incorrect parameters ,Because there is no handling for exception in the js code.
> 2.Error messages are not completely correct, it should be "Either type or enddate must be specified".
>
>
> Diffs
> -----
>
> ui/scripts/events.js 46d45c0
>
> Diff: https://reviews.apache.org/r/13770/diff/
>
>
> Testing
> -------
>
> 1.The loading screen will disappear when close the error message dialog.
> 2.The error message will be "Either type or enddate must be specified".
>
>
> Thanks,
>
> bo wang
>
>
Re: Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts screen
is in processing state forever with Delete Events/Alerts request having no
filter
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13770/#review26442
-----------------------------------------------------------
Commit 38b94e934c38556ed3974ab16a35d5be33f4edc4 in branch refs/heads/master from brito wang
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=38b94e9 ]
CLOUDSTACK-3363 UI > fix list Events/Alerts screen is in processing state forever with Delete Events/Alerts request having no filter
- ASF Subversion and Git Services
On Aug. 28, 2013, 7:46 a.m., bo wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13770/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 7:46 a.m.)
>
>
> Review request for cloudstack, Brian Federle and bharat kumar.
>
>
> Bugs: CLOUDSTACK-3363
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1.The loading screen won't disappear when delete the events or alerts with incorrect parameters ,Because there is no handling for exception in the js code.
> 2.Error messages are not completely correct, it should be "Either type or enddate must be specified".
>
>
> Diffs
> -----
>
> ui/scripts/events.js 46d45c0
>
> Diff: https://reviews.apache.org/r/13770/diff/
>
>
> Testing
> -------
>
> 1.The loading screen will disappear when close the error message dialog.
> 2.The error message will be "Either type or enddate must be specified".
>
>
> Thanks,
>
> bo wang
>
>
Re: Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts screen
is in processing state forever with Delete Events/Alerts request having no
filter
Posted by bo wang <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13770/
-----------------------------------------------------------
(Updated Aug. 28, 2013, 3:46 p.m.)
Review request for cloudstack, Brian Federle and bharat kumar.
Changes
-------
Only modify the file event.js to handle ajax request exceptions.
Bugs: CLOUDSTACK-3363
Repository: cloudstack-git
Description
-------
1.The loading screen won't disappear when delete the events or alerts with incorrect parameters ,Because there is no handling for exception in the js code.
2.Error messages are not completely correct, it should be "Either type or enddate must be specified".
Diffs (updated)
-----
ui/scripts/events.js 46d45c0
Diff: https://reviews.apache.org/r/13770/diff/
Testing
-------
1.The loading screen will disappear when close the error message dialog.
2.The error message will be "Either type or enddate must be specified".
Thanks,
bo wang