You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2014/05/20 19:55:55 UTC
Review Request 21718: Update gitignore template
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-654
https://issues.apache.org/jira/browse/MESOS-654
Repository: mesos-git
Description
-------
Adding missing files to gitignore template
Diffs
-----
.gitignore-template f7654a4
Diff: https://reviews.apache.org/r/21718/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 21718: Update gitignore template
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/#review45754
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On May 20, 2014, 6:13 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21718/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 6:13 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding missing files to gitignore template
>
>
> Diffs
> -----
>
> .gitignore-template f7654a4
>
> Diff: https://reviews.apache.org/r/21718/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 21718: Update gitignore template
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/#review44254
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21718]
All tests passed.
- Mesos ReviewBot
On May 20, 2014, 6:13 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21718/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 6:13 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding missing files to gitignore template
>
>
> Diffs
> -----
>
> .gitignore-template f7654a4
>
> Diff: https://reviews.apache.org/r/21718/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 21718: Update gitignore template
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/#review43806
-----------------------------------------------------------
Ship it!
Ship It!
.gitignore-template
<https://reviews.apache.org/r/21718/#comment78090>
Haven't seen this getting created yet on any of my build systems. But given that it appears to be kinda standard (https://github.com/github/gitignore/blob/master/Autotools.gitignore) to exclude it, I guess that is fine.
- Till Toenshoff
On May 20, 2014, 6:13 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21718/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 6:13 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding missing files to gitignore template
>
>
> Diffs
> -----
>
> .gitignore-template f7654a4
>
> Diff: https://reviews.apache.org/r/21718/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 21718: Update gitignore template
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On May 20, 2014, 6:13 p.m., Jay Buffington wrote:
> > .gitignore-template, line 21
> > <https://reviews.apache.org/r/21718/diff/3/?file=585304#file585304line21>
> >
> > Shouldn't this line live in https://github.com/3rdparty/libprocess/blob/master/.gitignore ?
> >
> > It's not 100% clear to me how 3rdparty modules are pulled in. They're not git submodules, right? They are actually copied into the repo?
Sorry I just updated
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/#review43509
-----------------------------------------------------------
On May 20, 2014, 6:13 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21718/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 6:13 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding missing files to gitignore template
>
>
> Diffs
> -----
>
> .gitignore-template f7654a4
>
> Diff: https://reviews.apache.org/r/21718/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 21718: Update gitignore template
Posted by Jay Buffington <me...@jaybuff.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/#review43509
-----------------------------------------------------------
.gitignore-template
<https://reviews.apache.org/r/21718/#comment77697>
Shouldn't this line live in https://github.com/3rdparty/libprocess/blob/master/.gitignore ?
It's not 100% clear to me how 3rdparty modules are pulled in. They're not git submodules, right? They are actually copied into the repo?
- Jay Buffington
On May 20, 2014, 6:13 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21718/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 6:13 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-654
> https://issues.apache.org/jira/browse/MESOS-654
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Adding missing files to gitignore template
>
>
> Diffs
> -----
>
> .gitignore-template f7654a4
>
> Diff: https://reviews.apache.org/r/21718/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 21718: Update gitignore template
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/
-----------------------------------------------------------
(Updated May 20, 2014, 6:13 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-654
https://issues.apache.org/jira/browse/MESOS-654
Repository: mesos-git
Description
-------
Adding missing files to gitignore template
Diffs (updated)
-----
.gitignore-template f7654a4
Diff: https://reviews.apache.org/r/21718/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 21718: Update gitignore template
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/
-----------------------------------------------------------
(Updated May 20, 2014, 6:11 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-654
https://issues.apache.org/jira/browse/MESOS-654
Repository: mesos-git
Description
-------
Adding missing files to gitignore template
Diffs (updated)
-----
.gitignore-template f7654a4
Diff: https://reviews.apache.org/r/21718/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 21718: Update gitignore template
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/
-----------------------------------------------------------
(Updated May 20, 2014, 6:02 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-654
https://issues.apache.org/jira/browse/MESOS-654
Repository: mesos-git
Description
-------
Adding missing files to gitignore template
Diffs (updated)
-----
.gitignore-template f7654a4
Diff: https://reviews.apache.org/r/21718/diff/
Testing
-------
Thanks,
Isabel Jimenez
Re: Review Request 21718: Update gitignore template
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21718/
-----------------------------------------------------------
(Updated May 20, 2014, 6 p.m.)
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-654
https://issues.apache.org/jira/browse/MESOS-654
Repository: mesos-git
Description
-------
Adding missing files to gitignore template
Diffs (updated)
-----
.gitignore-template f7654a4
Diff: https://reviews.apache.org/r/21718/diff/
Testing
-------
Thanks,
Isabel Jimenez