You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/22 06:54:35 UTC
[GitHub] [shardingsphere] liuqian1990 opened a new pull request #8716: Update authentication.cn.md
liuqian1990 opened a new pull request #8716:
URL: https://github.com/apache/shardingsphere/pull/8716
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
-
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #8716: Update authentication.cn.md
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #8716:
URL: https://github.com/apache/shardingsphere/pull/8716#issuecomment-750188442
Can you update your change which followed by code review suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #8716: Update authentication.cn.md
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #8716:
URL: https://github.com/apache/shardingsphere/pull/8716#discussion_r547162609
##########
File path: docs/document/content/user-manual/shardingsphere-proxy/configuration/authentication.cn.md
##########
@@ -10,8 +10,8 @@ weight = 2
authentication:
users:
root: # 自定义用户名
- password: root # 自定义用户名
+ password: root # 自定义用户名密码
Review comment:
It is better for 自定义用户名`的`密码
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] liuqian1990 commented on pull request #8716: Update authentication.cn.md
Posted by GitBox <gi...@apache.org>.
liuqian1990 commented on pull request #8716:
URL: https://github.com/apache/shardingsphere/pull/8716#issuecomment-749506884
english doc No error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #8716: Update authentication.cn.md
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #8716:
URL: https://github.com/apache/shardingsphere/pull/8716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on pull request #8716: Update authentication.cn.md
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #8716:
URL: https://github.com/apache/shardingsphere/pull/8716#issuecomment-749440489
Can you check english doc too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org