You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "kevinrr888 (via GitHub)" <gi...@apache.org> on 2025/12/18 15:53:52 UTC
[PR] Fix failing 2.1 tests [accumulo]
kevinrr888 opened a new pull request, #6028:
URL: https://github.com/apache/accumulo/pull/6028
PR #5990 intruduced stricter checks to NewTableConfiguration to check that properties or iterators set on the NewTableConfiguration do not conflict with default table properties or iterators. These tests were setting properties which did conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix failing 2.1 tests [accumulo]
Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 commented on code in PR #6028:
URL: https://github.com/apache/accumulo/pull/6028#discussion_r2631678411
##########
core/src/main/java/org/apache/accumulo/core/client/admin/NewTableConfiguration.java:
##########
@@ -206,7 +206,8 @@ public Map<String,String> getProperties() {
try {
TableOperationsHelper.checkIteratorConflicts(noDefaultsPropMap, setting, scopes);
} catch (AccumuloException e) {
- throw new IllegalStateException(e);
+ throw new IllegalStateException(String.format(
+ "conflict with default table iterator: scopes: %s setting: %s", scopes, setting), e);
}
});
Review Comment:
checkIteratorConflicts() is intended to check if the "setting" conflicts with any prop in the prop map. Here we are using it the other way around, so the exception message was lacking helpful info. Added more info here.
Here is an example of the previous exception:
```
java.lang.IllegalStateException: org.apache.accumulo.core.client.AccumuloException: java.lang.IllegalArgumentException: iterator priority conflict: table.iterator.minc.NullIterator=20,org.apache.accumulo.test.functional.FlushNoFileIT$NullIterator
at org.apache.accumulo.core.client.admin.NewTableConfiguration.lambda$getProperties$1(NewTableConfiguration.java:209)
at java.base/java.util.Map.forEach(Map.java:713)
at org.apache.accumulo.core.client.admin.NewTableConfiguration.getProperties(NewTableConfiguration.java:205)
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.create(TableOperationsImpl.java:250)
at org.apache.accumulo.test.functional.FlushNoFileIT.test(FlushNoFileIT.java:75)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: org.apache.accumulo.core.client.AccumuloException: java.lang.IllegalArgumentException: iterator priority conflict: table.iterator.minc.NullIterator=20,org.apache.accumulo.test.functional.FlushNoFileIT$NullIterator
at org.apache.accumulo.core.clientImpl.TableOperationsHelper.checkIteratorConflicts(TableOperationsHelper.java:168)
at org.apache.accumulo.core.client.admin.NewTableConfiguration.lambda$getProperties$1(NewTableConfiguration.java:207)
... 9 more
Caused by: java.lang.IllegalArgumentException: iterator priority conflict: table.iterator.minc.NullIterator=20,org.apache.accumulo.test.functional.FlushNoFileIT$NullIterator
... 11 more
```
Here is the new exception message:
```
java.lang.IllegalStateException: conflict with default table iterator: scopes: [majc, minc, scan] setting: name:vers, priority:20, class:org.apache.accumulo.core.iterators.user.VersioningIterator, properties:{maxVersions=1}
at org.apache.accumulo.core.client.admin.NewTableConfiguration.lambda$getProperties$1(NewTableConfiguration.java:209)
at java.base/java.util.Map.forEach(Map.java:713)
at org.apache.accumulo.core.client.admin.NewTableConfiguration.getProperties(NewTableConfiguration.java:205)
at org.apache.accumulo.core.clientImpl.TableOperationsImpl.create(TableOperationsImpl.java:250)
at org.apache.accumulo.test.functional.FlushNoFileIT.test(FlushNoFileIT.java:75)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:840)
Caused by: org.apache.accumulo.core.client.AccumuloException: java.lang.IllegalArgumentException: iterator priority conflict: table.iterator.minc.NullIterator=20,org.apache.accumulo.test.functional.FlushNoFileIT$NullIterator
at org.apache.accumulo.core.clientImpl.TableOperationsHelper.checkIteratorConflicts(TableOperationsHelper.java:168)
at org.apache.accumulo.core.client.admin.NewTableConfiguration.lambda$getProperties$1(NewTableConfiguration.java:207)
... 9 more
Caused by: java.lang.IllegalArgumentException: iterator priority conflict: table.iterator.minc.NullIterator=20,org.apache.accumulo.test.functional.FlushNoFileIT$NullIterator
... 11 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix failing 2.1 tests [accumulo]
Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 commented on code in PR #6028:
URL: https://github.com/apache/accumulo/pull/6028#discussion_r2632242556
##########
test/src/main/java/org/apache/accumulo/test/functional/FlushNoFileIT.java:
##########
@@ -68,7 +68,7 @@ public void test() throws Exception {
String tableName = getUniqueNames(1)[0];
NewTableConfiguration ntc = new NewTableConfiguration();
- IteratorSetting iteratorSetting = new IteratorSetting(20, NullIterator.class);
+ IteratorSetting iteratorSetting = new IteratorSetting(30, NullIterator.class);
Review Comment:
Yes VersioningIterator is set by default on tables with priority 20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix failing 2.1 tests [accumulo]
Posted by "kevinrr888 (via GitHub)" <gi...@apache.org>.
kevinrr888 merged PR #6028:
URL: https://github.com/apache/accumulo/pull/6028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix failing 2.1 tests [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #6028:
URL: https://github.com/apache/accumulo/pull/6028#discussion_r2632210742
##########
test/src/main/java/org/apache/accumulo/test/functional/FlushNoFileIT.java:
##########
@@ -68,7 +68,7 @@ public void test() throws Exception {
String tableName = getUniqueNames(1)[0];
NewTableConfiguration ntc = new NewTableConfiguration();
- IteratorSetting iteratorSetting = new IteratorSetting(20, NullIterator.class);
+ IteratorSetting iteratorSetting = new IteratorSetting(30, NullIterator.class);
Review Comment:
Is there a conflict at 20?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org