You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by jhaber <gi...@git.apache.org> on 2016/05/03 16:24:55 UTC
[GitHub] maven-shared pull request: Advance the index for longs and doubles
GitHub user jhaber opened a pull request:
https://github.com/apache/maven-shared/pull/10
Advance the index for longs and doubles
As you can see in the [stack overflow answer](http://stackoverflow.com/questions/32255023/how-would-i-go-about-parsing-the-java-class-file-constant-pool/32278587#32278587) this code was adapted from, the index must be advanced when you encounter a long or double. Without this change, you hit [this](https://github.com/apache/maven-shared/blob/ca1f714442eb49439a1f184ba8177e7795158b75/maven-dependency-analyzer/src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java#L96) exception on the next loop iteration.
I added an example of this to one of the test classes. Without the corresponding change to `ConstantPoolParser`, the test fails but it passes with this change.
@krosenvold @khmarbaise
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HubSpot/maven-shared trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-shared/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit 3006215ec2d89108812fabe0cadd578a3e465f7c
Author: Jonathan Haber <jh...@hubspot.com>
Date: 2016-05-03T14:17:51Z
Advance the index for longs and doubles
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-shared pull request #10: [MSHARED-545] Advance the index for longs and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/maven-shared/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org