You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jens-scheffler-bosch (via GitHub)" <gi...@apache.org> on 2023/02/04 22:53:09 UTC
[GitHub] [airflow] jens-scheffler-bosch opened a new pull request, #29376: Bugfix/26215 remove trigger UI glitches
jens-scheffler-bosch opened a new pull request, #29376:
URL: https://github.com/apache/airflow/pull/29376
This PR fixes some glitches that I found in the contribution of AIP-50 which slipped into the code at point of final review. I detected these during demo of the feature and hereby what to provide a fix.
Three glitches corrected with this PR:
- The DAG embedded javascript demo of the color slides in the example_params_ui_tutorial were broken
- The HTML dict formatting of the box/section "Generated Configuration JSON" in the new trigger UI (e.g. in "example_params_ui_tutorial" or other DAGs with a submit form was misaligned. setTimeout() event handler generates JavaScript error
- A TypeError was raised in JavaScript on first form submission when no "Select Recent Configurations" was rendered on page.
How to test that this fix works:
- Check out this branch, clean your dev env and re-compile www assets
- Start a local instance and open the browser to http://localhost:28080/trigger?dag_id=example_params_ui_tutorial
- See that (assuming you never ran the DAG) no JavaScript error is reported in JavaScript Developer Console
- Click on the gray section bar "Generated Configuration JSON" and see that dict formatting is "nice" (no mis-aligned text compared to main)
- Click on the gray section bar "Special advanced stuff with form fields" and use the sliders to adjust demo of color picker. See that color and text value adjusts when changing sliders and other way around if you change color code the sliders adjust. (was broken on main)
closes: #26215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jens-scheffler-bosch commented on pull request #29376: Bugfix/26215 remove trigger UI glitches
Posted by "jens-scheffler-bosch (via GitHub)" <gi...@apache.org>.
jens-scheffler-bosch commented on PR #29376:
URL: https://github.com/apache/airflow/pull/29376#issuecomment-1424293823
> @jens-scheffler-bosch Mind rebasing so the checks can pass?
Was not able to follow-up the status of red-main which I saw in slack, thanks for the hint, let's try to make pipeline green now :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #29376: Bugfix/26215 remove trigger UI glitches
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #29376:
URL: https://github.com/apache/airflow/pull/29376#issuecomment-1424276151
@jens-scheffler-bosch Mind rebasing so the checks can pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #29376: Bugfix/26215 remove trigger UI glitches
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #29376:
URL: https://github.com/apache/airflow/pull/29376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org