You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "XN137 (via GitHub)" <gi...@apache.org> on 2023/03/02 05:58:03 UTC

[GitHub] [iceberg] XN137 commented on a diff in pull request #6982: Build: Enable --scan for java-ci

XN137 commented on code in PR #6982:
URL: https://github.com/apache/iceberg/pull/6982#discussion_r1122628166


##########
.github/workflows/java-ci.yml:
##########
@@ -87,7 +87,7 @@ jobs:
       with:
         distribution: zulu
         java-version: 8
-    - run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest
+    - run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest --scan

Review Comment:
   doesnt this require to agree to gradle's terms of service?
   see https://docs.gradle.com/enterprise/gradle-plugin/#connecting_to_scans_gradle_com
   
   imo if the sporadic errors always happen in checkstyle part, we may want to check if we can upgrade the respective plugin to fix the issue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org