You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/07/27 21:24:18 UTC

[GitHub] [gobblin] arjun4084346 commented on a change in pull request #3340: [GOBBLIN-1497] Reduce the number of calls on FlowSpec initialization where possible,…

arjun4084346 commented on a change in pull request #3340:
URL: https://github.com/apache/gobblin/pull/3340#discussion_r677810833



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/restli/FlowConfigUtils.java
##########
@@ -60,7 +58,7 @@ public static FlowId deserializeFlowId(String serialized) throws IOException {
   }
 
   public static String serializeFlowConfig(FlowConfig flowConfig) throws IOException {
-    Properties properties = ConfigUtils.configToProperties(ConfigFactory.parseMap(flowConfig.getProperties()));
+    Properties properties = PropertiesUtils.stringMapToProperties(flowConfig.getProperties());

Review comment:
       `Properties properties = new Properties().putAll(flowConfig.getProperties());` works




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org