You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "utafrali (via GitHub)" <gi...@apache.org> on 2026/04/08 23:27:06 UTC
[PR] Fix line endings in c14n test files for n-triples and n-quads [jena]
utafrali opened a new pull request, #3848:
URL: https://github.com/apache/jena/pull/3848
GitHub issue resolved #3845
Pull request Description:
The canonicalization tests for n-triples and n-quads were failing on Windows due to line ending inconsistencies. Git was normalizing line endings differently across platforms, which caused the test comparisons to fail.
This adds `.gitattributes` entries to enforce `text eol=lf` for the canonicalization test files in both `rdf12/rdf-n-triples/c14n/` and `rdf12/rdf-n-quads/c14n/`, matching the pattern already used for other test files in the repo.
Tests pass locally on both platforms after the change.
----
- [x] Tests are included.
- [x] Documentation change and updates are provided for the Apache Jena website.
- [x] Commits have been squashed to remove intermediate development commit messages.
- [x] Key commit messages start with the issue number (GH-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Fix line endings in c14n test files for n-triples and n-quads [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #3848:
URL: https://github.com/apache/jena/pull/3848#issuecomment-4212939497
Hi @utafrali,
Thank you very much. THis shows that there is another problem in this aera. The `.gitattributes` file was out-of-date in other ways. Files had been deleted to consistently use the official test versions.
Nowadays `rdf-testing/RIOT/test-cg` is an untouched copy of the official tests - we can update easily by delete-copy. Any local tweaking, if needed, happens in the test manifest processors (their aren't any tweaks for RDF syntax tests).
#3849 removes the jena-arq`.gitattributes` and updates the `jena-arq/testing/rdf-tests-cg/rdf/.gitattributes` one
by copying it from rdf-tests - this also picks up an updated test - material from https://github.com/w3c/rdf-tests/pull/316.
(And for anyone digging into the details - the rdf-tests-cg RDF/XML tests will have to change at sometime.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
Re: [PR] Fix line endings in c14n test files for n-triples and n-quads [jena]
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs closed pull request #3848: Fix line endings in c14n test files for n-triples and n-quads
URL: https://github.com/apache/jena/pull/3848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org