You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/12/08 23:10:58 UTC
Review Request 28820: Simplified AllocatorTest.Whitelist by adding a
unit test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28820/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
This pulls out the AllocatorTest.Whitelist whitelisting integration test into a HierarchicalAllocatorTest.Whitelist unit test, and keeps AllocatorTest.Whitelist to test the wiring of the whitelist watcher in the master.
Note that reviewboard cannot display the changes to AllocatorTest.Whitelist, because the file was renamed in an earlier review in the chain. See the raw diff.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp PRE-CREATION
src/tests/master_allocator_tests.cpp 6422f29fd35e6c1989279a87da99950f2fdd186e
Diff: https://reviews.apache.org/r/28820/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 28820: Simplified AllocatorTest.Whitelist by
adding a unit test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28820/#review64600
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2014, 10:10 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28820/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2014, 10:10 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This pulls out the AllocatorTest.Whitelist whitelisting integration test into a HierarchicalAllocatorTest.Whitelist unit test, and keeps AllocatorTest.Whitelist to test the wiring of the whitelist watcher in the master.
>
> Note that reviewboard cannot display the changes to AllocatorTest.Whitelist, because the file was renamed in an earlier review in the chain. See the raw diff.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp PRE-CREATION
> src/tests/master_allocator_tests.cpp 6422f29fd35e6c1989279a87da99950f2fdd186e
>
> Diff: https://reviews.apache.org/r/28820/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>