You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/03/25 04:10:31 UTC

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages 

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17231


Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................

IMPALA-10608: Update kudu-python version and remove some unused packages

This updates kudu-python to version 1.14.0 (from 1.2.0).
As part of this, it disables ccache for bootstrap_virtualenv.py.
ccache wasn't working anyway, because pip install uses random
temporary directories. It also needs to copy a few files to
the build directory for the Kudu install. The advantage to
upgrading is that the new version no longer has a numpy dependency.

Additionally, this modifies a few minor packages:
 - virtualenv moves to the latest version prior to the rewrite
   that accompanied version 20 (i.e. 16.10.7).
 - setuptools moves to the last version that supports python 2.7 (44.1.1)
 - remove botos3, ipython, and ordereddict

These changes speed up installing the virtualenv
Before:
real	3m11.956s
user	2m49.620s
sys	0m14.266s
After:
real    1m38.798s
user    1m33.591s
sys     0m8.112s

Testing:
 - Hand tests, GVO run

Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
---
M bin/compare_branches.py
D bin/impala-ipython
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/kudu-requirements.txt
M infra/python/deps/requirements.txt
M infra/python/deps/setuptools-requirements.txt
6 files changed, 14 insertions(+), 59 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/17231/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17231/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17231/2//COMMIT_MSG@14
PS2, Line 14: no longer has a numpy dependency
Yay!



-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 20:27:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8442/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Mar 2021 04:29:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7007/


-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Mar 2021 19:06:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17231/1/bin/compare_branches.py
File bin/compare_branches.py:

http://gerrit.cloudera.org:8080/#/c/17231/1/bin/compare_branches.py@71
PS1, Line 71: from collections import OrderedDict
flake8: E402 module level import not at top of file



-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Mar 2021 04:11:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................

IMPALA-10608: Update kudu-python version and remove some unused packages

This updates kudu-python to version 1.14.0 (from 1.2.0).
As part of this, it disables ccache for bootstrap_virtualenv.py.
ccache wasn't working anyway, because pip install uses random
temporary directories. It also needs to copy a few files to
the build directory for the Kudu install. The advantage to
upgrading is that the new version no longer has a numpy dependency.

Additionally, this modifies a few minor packages:
 - virtualenv moves to the latest version prior to the rewrite
   that accompanied version 20 (i.e. 16.10.7).
 - setuptools moves to the last version that supports python 2.7 (44.1.1)
 - remove botos3, ipython, and ordereddict

These changes speed up installing the virtualenv
Before:
real	3m11.956s
user	2m49.620s
sys	0m14.266s
After:
real    1m38.798s
user    1m33.591s
sys     0m8.112s

Testing:
 - Hand tests, GVO run

Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Reviewed-on: http://gerrit.cloudera.org:8080/17231
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/compare_branches.py
D bin/impala-ipython
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/kudu-requirements.txt
M infra/python/deps/requirements.txt
M infra/python/deps/setuptools-requirements.txt
M tests/comparison/cluster.py
7 files changed, 15 insertions(+), 60 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7023/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 21:21:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 3: Code-Review+2

Only change is to the requests version that got updated, carrying +2


-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 21:21:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8446/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Mar 2021 20:53:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17231

to look at the new patch set (#2).

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................

IMPALA-10608: Update kudu-python version and remove some unused packages

This updates kudu-python to version 1.14.0 (from 1.2.0).
As part of this, it disables ccache for bootstrap_virtualenv.py.
ccache wasn't working anyway, because pip install uses random
temporary directories. It also needs to copy a few files to
the build directory for the Kudu install. The advantage to
upgrading is that the new version no longer has a numpy dependency.

Additionally, this modifies a few minor packages:
 - virtualenv moves to the latest version prior to the rewrite
   that accompanied version 20 (i.e. 16.10.7).
 - setuptools moves to the last version that supports python 2.7 (44.1.1)
 - remove botos3, ipython, and ordereddict

These changes speed up installing the virtualenv
Before:
real	3m11.956s
user	2m49.620s
sys	0m14.266s
After:
real    1m38.798s
user    1m33.591s
sys     0m8.112s

Testing:
 - Hand tests, GVO run

Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
---
M bin/compare_branches.py
D bin/impala-ipython
M infra/python/bootstrap_virtualenv.py
M infra/python/deps/kudu-requirements.txt
M infra/python/deps/requirements.txt
M infra/python/deps/setuptools-requirements.txt
M tests/comparison/cluster.py
7 files changed, 15 insertions(+), 60 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/17231/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7007/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Mar 2021 17:44:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Mar 2021 08:06:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17231/2/bin/compare_branches.py
File bin/compare_branches.py:

http://gerrit.cloudera.org:8080/#/c/17231/2/bin/compare_branches.py@71
PS2, Line 71: from collections import OrderedDict
flake8: E402 module level import not at top of file



-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Mar 2021 20:34:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7010/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Mar 2021 02:07:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10608: Update kudu-python version and remove some unused packages

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17231 )

Change subject: IMPALA-10608: Update kudu-python version and remove some unused packages
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib47770df9e46de448fe2bffef7abe2c3aa942fb9
Gerrit-Change-Number: 17231
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 03:07:43 +0000
Gerrit-HasComments: No