You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2015/12/09 04:15:48 UTC

[GitHub] spark pull request: [SPARK-12188] [SQL] [FOLLOW-UP] Code refactori...

GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/10214

    [SPARK-12188] [SQL] [FOLLOW-UP] Code refactoring and comment correction in Dataset APIs

    @marmbrus This PR is to address your comment. Thanks for your review! 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark followup12188

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/10214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #10214
    
----
commit 145cd5b5e5b0ad4a229e1621acaf26d02d25cd41
Author: gatorsmile <ga...@gmail.com>
Date:   2015-12-09T03:10:33Z

    address the comments.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-12188] [SQL] [FOLLOW-UP] Code refactori...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/10214#issuecomment-163093055
  
    **[Test build #47400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47400/consoleFull)** for PR 10214 at commit [`145cd5b`](https://github.com/apache/spark/commit/145cd5b5e5b0ad4a229e1621acaf26d02d25cd41).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-12188] [SQL] [FOLLOW-UP] Code refactori...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/10214#issuecomment-163108147
  
    **[Test build #47400 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47400/consoleFull)** for PR 10214 at commit [`145cd5b`](https://github.com/apache/spark/commit/145cd5b5e5b0ad4a229e1621acaf26d02d25cd41).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-12188] [SQL] [FOLLOW-UP] Code refactori...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/10214#issuecomment-163108214
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-12188] [SQL] [FOLLOW-UP] Code refactori...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/10214


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-12188] [SQL] [FOLLOW-UP] Code refactori...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/10214#issuecomment-163108215
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47400/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org