You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/06/13 02:55:34 UTC
[PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Ma77Ball opened a new pull request, #5673:
URL: https://github.com/apache/texera/pull/5673
> Stacked on #5545 (adds the `/config/amber` endpoint and the `amber` config source this PR namespaces). Base diff includes #5545 until it merges; review the last commit only, or after #5545 lands. Kept as a draft for that reason.
### What changes were proposed in this PR?
- Changed `GuiConfigService` to store each endpoint's payload under its own key in a `configBySource` map (`preLogin`, `gui`, `amber`, `userSystem`) instead of spreading them all into one flat object, so the origin of every config value is preserved (addresses the review comment on #5545).
- Derived the existing flat `env` getter from `configBySource` on read, keeping its shape identical so the ~50 existing `guiConfigService.env.<flag>` call sites are untouched.
- Added a `source(name)` accessor that returns one endpoint's payload in isolation.
- Added unit tests for the isolation guarantees (each source retrievable alone, no key bleed across sources, empty object for an unloaded source).
### Any related issues, documentation, discussions?
Closes: #5669
### How was this PR tested?
- Run `cd frontend && npx ng test --include="src/app/common/service/gui-config.service.spec.ts"` and expect 11 passed (8 existing merge/orchestration tests plus 3 new source-isolation tests).
- Confirm the merged view is unchanged: `service.env.defaultDataTransferBatchSize` still resolves after post-login load, while `service.source("amber")` returns only the amber payload and `service.source("gui")` does not contain `defaultDataTransferBatchSize`.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #5673:
URL: https://github.com/apache/texera/pull/5673#issuecomment-4760591317
/request-review @aicam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5673:
URL: https://github.com/apache/texera/pull/5673#issuecomment-4766237746
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Posted by "aicam (via GitHub)" <gi...@apache.org>.
aicam commented on PR #5673:
URL: https://github.com/apache/texera/pull/5673#issuecomment-4770334262
@chenlica It seems some changes were due to merge conflict so now there are 2 files changed overall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #5673:
URL: https://github.com/apache/texera/pull/5673#issuecomment-4765073162
@aicam This PR has 6 files. Did you go through all the lines of code? If so, did you have any comments on some of the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5673:
URL: https://github.com/apache/texera/pull/5673#issuecomment-4697240910
<!-- texera-benchmarks-comment -->
## ✅ No material benchmark regressions detected
🟢 12 better · 🔴 0 worse · ⚪ 3 noise (<±5%) · 0 without baseline
> CI benchmark results are noisy; treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/27454487535)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🟢 | bs=10 sw=10 sl=64 | 390 | 0.238 | 25,233/35,168/35,168 us | 🟢 -8.3% / ⚪ within ±5% |
| 🟢 | bs=100 sw=10 sl=64 | 919 | 0.561 | 105,293/133,992/133,992 us | 🟢 +26.1% / 🟢 -8.3% |
| 🟢 | bs=1000 sw=10 sl=64 | 1,118 | 0.682 | 894,696/941,525/941,525 us | 🟢 +18.1% / 🟢 +10.7% |
<details><summary>Baseline details</summary>
Latest main `7ae9b35` from 2026-06-13T00:44:28.840Z
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 390 tuples/sec | 394.18 tuples/sec | 400.34 tuples/sec | -1.1% | -2.6% |
| bs=10 sw=10 sl=64 | MB/s | 0.238 MB/s | 0.241 MB/s | 0.244 MB/s | -1.1% | -2.6% |
| bs=10 sw=10 sl=64 | p50 | 25,233 us | 24,805 us | 24,191 us | +1.7% | +4.3% |
| bs=10 sw=10 sl=64 | p95 | 35,168 us | 38,345 us | 36,018 us | -8.3% | -2.4% |
| bs=10 sw=10 sl=64 | p99 | 35,168 us | 38,345 us | 36,018 us | -8.3% | -2.4% |
| bs=100 sw=10 sl=64 | throughput | 919 tuples/sec | 729.17 tuples/sec | 867.19 tuples/sec | +26.0% | +6.0% |
| bs=100 sw=10 sl=64 | MB/s | 0.561 MB/s | 0.445 MB/s | 0.529 MB/s | +26.1% | +6.0% |
| bs=100 sw=10 sl=64 | p50 | 105,293 us | 133,219 us | 114,874 us | -21.0% | -8.3% |
| bs=100 sw=10 sl=64 | p95 | 133,992 us | 173,178 us | 142,264 us | -22.6% | -5.8% |
| bs=100 sw=10 sl=64 | p99 | 133,992 us | 173,178 us | 142,264 us | -22.6% | -5.8% |
| bs=1000 sw=10 sl=64 | throughput | 1,118 tuples/sec | 946.3 tuples/sec | 1,010 tuples/sec | +18.1% | +10.7% |
| bs=1000 sw=10 sl=64 | MB/s | 0.682 MB/s | 0.578 MB/s | 0.616 MB/s | +18.1% | +10.7% |
| bs=1000 sw=10 sl=64 | p50 | 894,696 us | 1,059,718 us | 995,071 us | -15.6% | -10.1% |
| bs=1000 sw=10 sl=64 | p95 | 941,525 us | 1,104,221 us | 1,046,228 us | -14.7% | -10.0% |
| bs=1000 sw=10 sl=64 | p99 | 941,525 us | 1,104,221 us | 1,046,228 us | -14.7% | -10.0% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,512.23,200,128000,390,0.238,25233.13,35167.89,35167.89
1,100,10,64,20,2176.11,2000,1280000,919,0.561,105292.72,133991.67,133991.67
2,1000,10,64,20,17885.95,20000,12800000,1118,0.682,894695.81,941525.09,941525.09
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5673:
URL: https://github.com/apache/texera/pull/5673#issuecomment-4697234591
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5673?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.25%. Comparing base ([`7ae9b35`](https://app.codecov.io/gh/apache/texera/commit/7ae9b35f12748616daf7bcc925fdde2e5def5187?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6b68a32`](https://app.codecov.io/gh/apache/texera/commit/6b68a328233ff9099b2aa038dc8ff2f016e42a18?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5673 +/- ##
============================================
+ Coverage 53.02% 54.25% +1.23%
+ Complexity 2542 1464 -1078
============================================
Files 1075 807 -268
Lines 41743 33566 -8177
Branches 4513 3399 -1114
============================================
- Hits 22134 18212 -3922
+ Misses 18301 14457 -3844
+ Partials 1308 897 -411
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `71.42% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [a4153ca](https://app.codecov.io/gh/apache/texera/commit/a4153caa7a13b527750ab2f3d91b578170bc744f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.26% <ø> (+6.34%)` | :arrow_up: | Carriedforward from [a4153ca](https://app.codecov.io/gh/apache/texera/commit/a4153caa7a13b527750ab2f3d91b578170bc744f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <ø> (ø)` | | Carriedforward from [a4153ca](https://app.codecov.io/gh/apache/texera/commit/a4153caa7a13b527750ab2f3d91b578170bc744f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.35% <100.00%> (+0.63%)` | :arrow_up: | Carriedforward from [a4153ca](https://app.codecov.io/gh/apache/texera/commit/a4153caa7a13b527750ab2f3d91b578170bc744f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.06% <ø> (ø)` | | Carriedforward from [a4153ca](https://app.codecov.io/gh/apache/texera/commit/a4153caa7a13b527750ab2f3d91b578170bc744f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.35% <100.00%> (-0.03%)` | :arrow_down: | Carriedforward from [a4153ca](https://app.codecov.io/gh/apache/texera/commit/a4153caa7a13b527750ab2f3d91b578170bc744f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.70% <ø> (-0.02%)` | :arrow_down: | Carriedforward from [a4153ca](https://app.codecov.io/gh/apache/texera/commit/a4153caa7a13b527750ab2f3d91b578170bc744f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.74% <ø> (ø)` | | Carriedforward from [a4153ca](https://app.codecov.io/gh/apache/texera/commit/a4153caa7a13b527750ab2f3d91b578170bc744f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | Carriedforward from [a4153ca](https://app.codecov.io/gh/apache/texera/commit/a4153caa7a13b527750ab2f3d91b578170bc744f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5673?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #5673:
URL: https://github.com/apache/texera/pull/5673#issuecomment-4776574914
Good to know. Please review these two files carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #5673:
URL: https://github.com/apache/texera/pull/5673#issuecomment-4760870752
@aicam Please review it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): preserve config source in GuiConfigService instead of one flat map [texera]
Posted by "aicam (via GitHub)" <gi...@apache.org>.
aicam merged PR #5673:
URL: https://github.com/apache/texera/pull/5673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org