You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Shawn Jiang (JIRA)" <ji...@apache.org> on 2011/07/02 07:47:30 UTC
[jira] [Commented] (OPENEJB-1618) Seem to be caching proxies in
JNDI
[ https://issues.apache.org/jira/browse/OPENEJB-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058985#comment-13058985 ]
Shawn Jiang commented on OPENEJB-1618:
--------------------------------------
Hi Jonathan,
This commit brought lots of ejb regressions on geronimo tck. One of the errors I can see is:
Error in Main: java.lang.ClassFormatError: Illegal class name "Lorg/apache/openejb/core/ivm/IntraVmProxy;" in class file xxxxx/xxx/xxx/xxx/xxManagedBean$LocalBeanProxy.
Because geronimo is in a tight schedule, I'm going to revert it for now if no objection.
--------------------------------------------------------
ASF #1141732 Thu Jun 30 21:42:27 UTC 2011 jgallimore OPENEJB-1618 don't cache anything that implements IntraVmProxy, make no-interface proxies implement IntraVmProxy as well
Files Changed
MODIFY /openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImplTest.java
MODIFY /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java
MODIFY /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImpl.java
> Seem to be caching proxies in JNDI
> ----------------------------------
>
> Key: OPENEJB-1618
> URL: https://issues.apache.org/jira/browse/OPENEJB-1618
> Project: OpenEJB
> Issue Type: Bug
> Components: container system
> Reporter: Jonathan Gallimore
> Assignee: Jonathan Gallimore
> Priority: Minor
>
> There seems to be a case where a proxy can be cached in IvmContext instead of the reference. This can cause instances that have had an @Remove method called to be returned from a JNDI lookup without a create method being called.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (OPENEJB-1618) Seem to be caching proxies in JNDI
Posted by Jonathan Gallimore <jo...@gmail.com>.
Hi Shawn,
I committed this again (r1142239) - the Geronimo TCK test seemed to work for
me. Please feel free to revert it if it does cause any problems.
Regards
Jon
On Sat, Jul 2, 2011 at 10:08 AM, Shawn Jiang <ge...@gmail.com> wrote:
> I send a mail on the regression to geronimo tck list, please check
> that when you have a chance to run geornimo tck against your changes.
>
> On Sat, Jul 2, 2011 at 4:55 PM, Jonathan Gallimore
> <jo...@gmail.com> wrote:
> > Thanks Shawn. I would be good to get the IvmContext change back in but
> leave
> > the LocalBeanProxyGenerator change out. I'll try some Geronimo TCK tests
> > here this morning and see how that does.
> >
> > Jon
> >
> > On Sat, Jul 2, 2011 at 9:20 AM, Shawn Jiang <ge...@gmail.com> wrote:
> >
> >> Thank you for your quick response. Just reverted it with #1142169
> >>
> >> On Sat, Jul 2, 2011 at 3:35 PM, Jonathan Gallimore
> >> <jo...@gmail.com> wrote:
> >> > No problem, go ahead and revert it and I'll take another look at it.
> >> Sorry
> >> > if its caused any hassle. I'll see if I can run the relevant geronimo
> >> tests
> >> > when I try and fix it.
> >> >
> >> > Jon
> >> > On 2 Jul 2011 06:48, "Shawn Jiang (JIRA)" <ji...@apache.org> wrote:
> >> >>
> >> >> [
> >> >
> >>
> https://issues.apache.org/jira/browse/OPENEJB-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058985#comment-13058985
> >> ]
> >> >>
> >> >> Shawn Jiang commented on OPENEJB-1618:
> >> >> --------------------------------------
> >> >>
> >> >> Hi Jonathan,
> >> >>
> >> >> This commit brought lots of ejb regressions on geronimo tck. One of
> the
> >> > errors I can see is:
> >> >>
> >> >> Error in Main: java.lang.ClassFormatError: Illegal class name
> >> > "Lorg/apache/openejb/core/ivm/IntraVmProxy;" in class file
> >> > xxxxx/xxx/xxx/xxx/xxManagedBean$LocalBeanProxy.
> >> >>
> >> >> Because geronimo is in a tight schedule, I'm going to revert it for
> now
> >> if
> >> > no objection.
> >> >>
> >> >>
> >> >> --------------------------------------------------------
> >> >> ASF #1141732 Thu Jun 30 21:42:27 UTC 2011 jgallimore OPENEJB-1618
> don't
> >> > cache anything that implements IntraVmProxy, make no-interface proxies
> >> > implement IntraVmProxy as well
> >> >> Files Changed
> >> >> MODIFY
> >> >
> >>
> /openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImplTest.java
> >> >> MODIFY
> >> >
> >>
> /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java
> >> >> MODIFY
> >> >
> >>
> /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImpl.java
> >> >
> >> >>
> >> >>> Seem to be caching proxies in JNDI
> >> >>> ----------------------------------
> >> >>>
> >> >>> Key: OPENEJB-1618
> >> >>> URL: https://issues.apache.org/jira/browse/OPENEJB-1618
> >> >>> Project: OpenEJB
> >> >>> Issue Type: Bug
> >> >>> Components: container system
> >> >>> Reporter: Jonathan Gallimore
> >> >>> Assignee: Jonathan Gallimore
> >> >>> Priority: Minor
> >> >>>
> >> >>> There seems to be a case where a proxy can be cached in IvmContext
> >> > instead of the reference. This can cause instances that have had an
> >> @Remove
> >> > method called to be returned from a JNDI lookup without a create
> method
> >> > being called.
> >> >>
> >> >> --
> >> >> This message is automatically generated by JIRA.
> >> >> For more information on JIRA, see:
> >> http://www.atlassian.com/software/jira
> >> >>
> >> >>
> >> >
> >>
> >>
> >>
> >> --
> >> Shawn
> >>
> >
>
>
>
> --
> Shawn
>
Re: [jira] [Commented] (OPENEJB-1618) Seem to be caching proxies in JNDI
Posted by Shawn Jiang <ge...@gmail.com>.
I send a mail on the regression to geronimo tck list, please check
that when you have a chance to run geornimo tck against your changes.
On Sat, Jul 2, 2011 at 4:55 PM, Jonathan Gallimore
<jo...@gmail.com> wrote:
> Thanks Shawn. I would be good to get the IvmContext change back in but leave
> the LocalBeanProxyGenerator change out. I'll try some Geronimo TCK tests
> here this morning and see how that does.
>
> Jon
>
> On Sat, Jul 2, 2011 at 9:20 AM, Shawn Jiang <ge...@gmail.com> wrote:
>
>> Thank you for your quick response. Just reverted it with #1142169
>>
>> On Sat, Jul 2, 2011 at 3:35 PM, Jonathan Gallimore
>> <jo...@gmail.com> wrote:
>> > No problem, go ahead and revert it and I'll take another look at it.
>> Sorry
>> > if its caused any hassle. I'll see if I can run the relevant geronimo
>> tests
>> > when I try and fix it.
>> >
>> > Jon
>> > On 2 Jul 2011 06:48, "Shawn Jiang (JIRA)" <ji...@apache.org> wrote:
>> >>
>> >> [
>> >
>> https://issues.apache.org/jira/browse/OPENEJB-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058985#comment-13058985
>> ]
>> >>
>> >> Shawn Jiang commented on OPENEJB-1618:
>> >> --------------------------------------
>> >>
>> >> Hi Jonathan,
>> >>
>> >> This commit brought lots of ejb regressions on geronimo tck. One of the
>> > errors I can see is:
>> >>
>> >> Error in Main: java.lang.ClassFormatError: Illegal class name
>> > "Lorg/apache/openejb/core/ivm/IntraVmProxy;" in class file
>> > xxxxx/xxx/xxx/xxx/xxManagedBean$LocalBeanProxy.
>> >>
>> >> Because geronimo is in a tight schedule, I'm going to revert it for now
>> if
>> > no objection.
>> >>
>> >>
>> >> --------------------------------------------------------
>> >> ASF #1141732 Thu Jun 30 21:42:27 UTC 2011 jgallimore OPENEJB-1618 don't
>> > cache anything that implements IntraVmProxy, make no-interface proxies
>> > implement IntraVmProxy as well
>> >> Files Changed
>> >> MODIFY
>> >
>> /openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImplTest.java
>> >> MODIFY
>> >
>> /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java
>> >> MODIFY
>> >
>> /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImpl.java
>> >
>> >>
>> >>> Seem to be caching proxies in JNDI
>> >>> ----------------------------------
>> >>>
>> >>> Key: OPENEJB-1618
>> >>> URL: https://issues.apache.org/jira/browse/OPENEJB-1618
>> >>> Project: OpenEJB
>> >>> Issue Type: Bug
>> >>> Components: container system
>> >>> Reporter: Jonathan Gallimore
>> >>> Assignee: Jonathan Gallimore
>> >>> Priority: Minor
>> >>>
>> >>> There seems to be a case where a proxy can be cached in IvmContext
>> > instead of the reference. This can cause instances that have had an
>> @Remove
>> > method called to be returned from a JNDI lookup without a create method
>> > being called.
>> >>
>> >> --
>> >> This message is automatically generated by JIRA.
>> >> For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Shawn
>>
>
--
Shawn
Re: [jira] [Commented] (OPENEJB-1618) Seem to be caching proxies in JNDI
Posted by Jonathan Gallimore <jo...@gmail.com>.
Thanks Shawn. I would be good to get the IvmContext change back in but leave
the LocalBeanProxyGenerator change out. I'll try some Geronimo TCK tests
here this morning and see how that does.
Jon
On Sat, Jul 2, 2011 at 9:20 AM, Shawn Jiang <ge...@gmail.com> wrote:
> Thank you for your quick response. Just reverted it with #1142169
>
> On Sat, Jul 2, 2011 at 3:35 PM, Jonathan Gallimore
> <jo...@gmail.com> wrote:
> > No problem, go ahead and revert it and I'll take another look at it.
> Sorry
> > if its caused any hassle. I'll see if I can run the relevant geronimo
> tests
> > when I try and fix it.
> >
> > Jon
> > On 2 Jul 2011 06:48, "Shawn Jiang (JIRA)" <ji...@apache.org> wrote:
> >>
> >> [
> >
> https://issues.apache.org/jira/browse/OPENEJB-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058985#comment-13058985
> ]
> >>
> >> Shawn Jiang commented on OPENEJB-1618:
> >> --------------------------------------
> >>
> >> Hi Jonathan,
> >>
> >> This commit brought lots of ejb regressions on geronimo tck. One of the
> > errors I can see is:
> >>
> >> Error in Main: java.lang.ClassFormatError: Illegal class name
> > "Lorg/apache/openejb/core/ivm/IntraVmProxy;" in class file
> > xxxxx/xxx/xxx/xxx/xxManagedBean$LocalBeanProxy.
> >>
> >> Because geronimo is in a tight schedule, I'm going to revert it for now
> if
> > no objection.
> >>
> >>
> >> --------------------------------------------------------
> >> ASF #1141732 Thu Jun 30 21:42:27 UTC 2011 jgallimore OPENEJB-1618 don't
> > cache anything that implements IntraVmProxy, make no-interface proxies
> > implement IntraVmProxy as well
> >> Files Changed
> >> MODIFY
> >
> /openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImplTest.java
> >> MODIFY
> >
> /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java
> >> MODIFY
> >
> /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImpl.java
> >
> >>
> >>> Seem to be caching proxies in JNDI
> >>> ----------------------------------
> >>>
> >>> Key: OPENEJB-1618
> >>> URL: https://issues.apache.org/jira/browse/OPENEJB-1618
> >>> Project: OpenEJB
> >>> Issue Type: Bug
> >>> Components: container system
> >>> Reporter: Jonathan Gallimore
> >>> Assignee: Jonathan Gallimore
> >>> Priority: Minor
> >>>
> >>> There seems to be a case where a proxy can be cached in IvmContext
> > instead of the reference. This can cause instances that have had an
> @Remove
> > method called to be returned from a JNDI lookup without a create method
> > being called.
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >>
> >>
> >
>
>
>
> --
> Shawn
>
Re: [jira] [Commented] (OPENEJB-1618) Seem to be caching proxies in JNDI
Posted by Shawn Jiang <ge...@gmail.com>.
Thank you for your quick response. Just reverted it with #1142169
On Sat, Jul 2, 2011 at 3:35 PM, Jonathan Gallimore
<jo...@gmail.com> wrote:
> No problem, go ahead and revert it and I'll take another look at it. Sorry
> if its caused any hassle. I'll see if I can run the relevant geronimo tests
> when I try and fix it.
>
> Jon
> On 2 Jul 2011 06:48, "Shawn Jiang (JIRA)" <ji...@apache.org> wrote:
>>
>> [
> https://issues.apache.org/jira/browse/OPENEJB-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058985#comment-13058985]
>>
>> Shawn Jiang commented on OPENEJB-1618:
>> --------------------------------------
>>
>> Hi Jonathan,
>>
>> This commit brought lots of ejb regressions on geronimo tck. One of the
> errors I can see is:
>>
>> Error in Main: java.lang.ClassFormatError: Illegal class name
> "Lorg/apache/openejb/core/ivm/IntraVmProxy;" in class file
> xxxxx/xxx/xxx/xxx/xxManagedBean$LocalBeanProxy.
>>
>> Because geronimo is in a tight schedule, I'm going to revert it for now if
> no objection.
>>
>>
>> --------------------------------------------------------
>> ASF #1141732 Thu Jun 30 21:42:27 UTC 2011 jgallimore OPENEJB-1618 don't
> cache anything that implements IntraVmProxy, make no-interface proxies
> implement IntraVmProxy as well
>> Files Changed
>> MODIFY
> /openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImplTest.java
>> MODIFY
> /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java
>> MODIFY
> /openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImpl.java
>
>>
>>> Seem to be caching proxies in JNDI
>>> ----------------------------------
>>>
>>> Key: OPENEJB-1618
>>> URL: https://issues.apache.org/jira/browse/OPENEJB-1618
>>> Project: OpenEJB
>>> Issue Type: Bug
>>> Components: container system
>>> Reporter: Jonathan Gallimore
>>> Assignee: Jonathan Gallimore
>>> Priority: Minor
>>>
>>> There seems to be a case where a proxy can be cached in IvmContext
> instead of the reference. This can cause instances that have had an @Remove
> method called to be returned from a JNDI lookup without a create method
> being called.
>>
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>
>>
>
--
Shawn
Re: [jira] [Commented] (OPENEJB-1618) Seem to be caching proxies in JNDI
Posted by Jonathan Gallimore <jo...@gmail.com>.
No problem, go ahead and revert it and I'll take another look at it. Sorry
if its caused any hassle. I'll see if I can run the relevant geronimo tests
when I try and fix it.
Jon
On 2 Jul 2011 06:48, "Shawn Jiang (JIRA)" <ji...@apache.org> wrote:
>
> [
https://issues.apache.org/jira/browse/OPENEJB-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058985#comment-13058985]
>
> Shawn Jiang commented on OPENEJB-1618:
> --------------------------------------
>
> Hi Jonathan,
>
> This commit brought lots of ejb regressions on geronimo tck. One of the
errors I can see is:
>
> Error in Main: java.lang.ClassFormatError: Illegal class name
"Lorg/apache/openejb/core/ivm/IntraVmProxy;" in class file
xxxxx/xxx/xxx/xxx/xxManagedBean$LocalBeanProxy.
>
> Because geronimo is in a tight schedule, I'm going to revert it for now if
no objection.
>
>
> --------------------------------------------------------
> ASF #1141732 Thu Jun 30 21:42:27 UTC 2011 jgallimore OPENEJB-1618 don't
cache anything that implements IntraVmProxy, make no-interface proxies
implement IntraVmProxy as well
> Files Changed
> MODIFY
/openejb/trunk/openejb3/container/openejb-core/src/test/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImplTest.java
> MODIFY
/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/naming/IvmContext.java
> MODIFY
/openejb/trunk/openejb3/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/LocalBeanProxyGeneratorImpl.java
>
>> Seem to be caching proxies in JNDI
>> ----------------------------------
>>
>> Key: OPENEJB-1618
>> URL: https://issues.apache.org/jira/browse/OPENEJB-1618
>> Project: OpenEJB
>> Issue Type: Bug
>> Components: container system
>> Reporter: Jonathan Gallimore
>> Assignee: Jonathan Gallimore
>> Priority: Minor
>>
>> There seems to be a case where a proxy can be cached in IvmContext
instead of the reference. This can cause instances that have had an @Remove
method called to be returned from a JNDI lookup without a create method
being called.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>