You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/03/06 01:18:23 UTC

[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1285: [bug] move the time setting of the service to the disco layer

tianxiaoliang commented on a change in pull request #1285:
URL: https://github.com/apache/servicecomb-service-center/pull/1285#discussion_r820165750



##########
File path: server/service/disco/metadata.go
##########
@@ -69,6 +71,9 @@ func registerService(ctx context.Context, request *pb.CreateServiceRequest) (*pb
 		return nil, quotaErr
 	}
 
+	service.Timestamp = strconv.FormatInt(time.Now().Unix(), 10)

Review comment:
       10 is magic number




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org