[GitHub] [orc] ffacs commented on a diff in pull request #1454: ORC-1385: [C++] Support schema evolution of numeric types

["ffacs (via GitHub)" <gi...@apache.org>]

ffacs commented on code in PR #1454:
URL: https://github.com/apache/orc/pull/1454#discussion_r1155519354


##########
c++/include/orc/Vector.hh:
##########
@@ -53,6 +53,10 @@ namespace orc {
     // whether the vector batch is encoded
     bool isEncoded;
 
+    // whether the vector is not a numeric vector
+    // or it's created with the option useTightNumericVector
+    bool isTight = true;

Review Comment:
   But, what if the ColumnVectorBatch is created by another reader which was createed without the useTightNumericVector option?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org