[GitHub] [maven-dependency-plugin] michael-o commented on a change in pull request #160: MDEP-763 - Minor Improvements:

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #160:
URL: https://github.com/apache/maven-dependency-plugin/pull/160#discussion_r702280604



##########
File path: src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java
##########
@@ -325,7 +325,7 @@ protected void unpack( Artifact artifact, String type, File location, String inc
         catch ( ArchiverException e )
         {
             throw new MojoExecutionException( "Error unpacking file: " + file + " to: " + location
-                + System.lineSeparator() + e.toString(), e );
+                + System.lineSeparator() + e, e );

Review comment:
       I consider this pointless to incude `e.toString()` in the exception message. One already passed `e`. That is more than enough.

##########
File path: src/main/java/org/apache/maven/plugins/dependency/fromDependencies/BuildClasspathMojo.java
##########
@@ -347,7 +347,7 @@ private void storeClasspathFile( String cpString, File out )
         }
         catch ( IOException ex )
         {
-            throw new MojoExecutionException( "Error while writing to classpath file '" + out + "': " + ex.toString(),
+            throw new MojoExecutionException( "Error while writing to classpath file '" + out + "': " + ex,

Review comment:
       Same here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org