[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7317: Refine the implementation of rename

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #7317:
URL: https://github.com/apache/incubator-nuttx/pull/7317#discussion_r996337161


##########
fs/vfs/fs_rename.c:
##########
@@ -90,7 +90,7 @@ static int pseudorename(FAR const char *oldpath, FAR struct inode *oldinode,
         {
           inode_release(newinode);
           ret = OK;
-          goto errout; /* Bad naming, this is not an error case. */
+          goto errout; /* Same name, this is not an error case. */

Review Comment:
   @acassis the message is reported by mv command, not function Here is my test on WSL2:
   ```
   $ cat test.c
   #include <stdio.h>
   
   int main(int argc, char *argv[])
   {
       return rename(argv[1], argv[2]);
   }
   $ gcc test.c 
   $ ./a.out a.out a.out 
   $ echo $?
   0
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org