You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/07/20 03:38:51 UTC
Review Request 67986: Added rapidjson to the libprocess build.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67986/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benno Evers.
Bugs: MESOS-9092
https://issues.apache.org/jira/browse/MESOS-9092
Repository: mesos
Description
-------
This follows the approach used for picojson.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am d13e93f0ce8ae054161dcc4017b1f16d0d5596e1
3rdparty/libprocess/Makefile.am e0d35d9fdddcecf6498f9e617a9c5c604a7f9fc6
3rdparty/libprocess/configure.ac 7fa596aabf6f2082aa6cde2a36d8bae7becdef47
Diff: https://reviews.apache.org/r/67986/diff/1/
Testing
-------
Tested at the end of this chain, since this is split across stout/libprocess/mesos.
Thanks,
Benjamin Mahler
Re: Review Request 67986: Added rapidjson to the libprocess build.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67986/#review206277
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/configure.ac
Lines 902 (patched)
<https://reviews.apache.org/r/67986/#comment289180>
Same issue as in the prior review.
- Benno Evers
On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67986/
> -----------------------------------------------------------
>
> (Updated July 20, 2018, 3:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benno Evers.
>
>
> Bugs: MESOS-9092
> https://issues.apache.org/jira/browse/MESOS-9092
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This follows the approach used for picojson.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am d13e93f0ce8ae054161dcc4017b1f16d0d5596e1
> 3rdparty/libprocess/Makefile.am e0d35d9fdddcecf6498f9e617a9c5c604a7f9fc6
> 3rdparty/libprocess/configure.ac 7fa596aabf6f2082aa6cde2a36d8bae7becdef47
>
>
> Diff: https://reviews.apache.org/r/67986/diff/1/
>
>
> Testing
> -------
>
> Tested at the end of this chain, since this is split across stout/libprocess/mesos.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 67986: Added rapidjson to the libprocess build.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67986/#review206397
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67986/
> -----------------------------------------------------------
>
> (Updated July 20, 2018, 3:38 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benno Evers.
>
>
> Bugs: MESOS-9092
> https://issues.apache.org/jira/browse/MESOS-9092
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This follows the approach used for picojson.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am d13e93f0ce8ae054161dcc4017b1f16d0d5596e1
> 3rdparty/libprocess/Makefile.am e0d35d9fdddcecf6498f9e617a9c5c604a7f9fc6
> 3rdparty/libprocess/configure.ac 7fa596aabf6f2082aa6cde2a36d8bae7becdef47
>
>
> Diff: https://reviews.apache.org/r/67986/diff/2/
>
>
> Testing
> -------
>
> Tested at the end of this chain, since this is split across stout/libprocess/mesos.
>
>
> Thanks,
>
> Benjamin Mahler
>
>