You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by shen guoquan <gu...@intel.com> on 2015/03/17 09:23:27 UTC
Review Request 32154: SQOOP-2220: Fix the privilege check on job
using the link id not the connector id
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32154/
-----------------------------------------------------------
Review request for Sqoop, Abraham Elmahrek and richard zhou.
Repository: sqoop-sqoop2
Description
-------
The privilege check on job should use the link id not the connector id
Diffs
-----
common/src/main/java/org/apache/sqoop/model/MJob.java 4b5c896
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 551d5fe
Diff: https://reviews.apache.org/r/32154/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 32154: SQOOP-2220: Fix the privilege check on job
using the link id not the connector id
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32154/#review77532
-----------------------------------------------------------
Ship it!
LGTM except for one thing
common/src/main/java/org/apache/sqoop/model/MJob.java
<https://reviews.apache.org/r/32154/#comment125645>
getLinkId(Direction direction) instead? To be in line with getConnectorId?
- Abraham Elmahrek
On March 17, 2015, 8:23 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32154/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 8:23 a.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek and richard zhou.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> The privilege check on job should use the link id not the connector id
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MJob.java 4b5c896
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 551d5fe
>
> Diff: https://reviews.apache.org/r/32154/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 32154: SQOOP-2220: Fix the privilege check on job
using the link id not the connector id
Posted by richard zhou <ri...@intel.com>.
> On March 17, 2015, 8:28 a.m., richard zhou wrote:
> > Ship It!
LGTM
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32154/#review76718
-----------------------------------------------------------
On March 17, 2015, 8:23 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32154/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 8:23 a.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek and richard zhou.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> The privilege check on job should use the link id not the connector id
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MJob.java 4b5c896
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 551d5fe
>
> Diff: https://reviews.apache.org/r/32154/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 32154: SQOOP-2220: Fix the privilege check on job
using the link id not the connector id
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32154/#review76718
-----------------------------------------------------------
Ship it!
Ship It!
- richard zhou
On March 17, 2015, 8:23 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32154/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 8:23 a.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek and richard zhou.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> The privilege check on job should use the link id not the connector id
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MJob.java 4b5c896
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 551d5fe
>
> Diff: https://reviews.apache.org/r/32154/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>