You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/08/05 17:34:46 UTC

[GitHub] [samza] PawasChhokra commented on a change in pull request #1406: SAMZA-2561: Add config map to DiagnosticsManager

PawasChhokra commented on a change in pull request #1406:
URL: https://github.com/apache/samza/pull/1406#discussion_r465891747



##########
File path: samza-core/src/main/java/org/apache/samza/util/DiagnosticsUtil.java
##########
@@ -70,7 +70,7 @@ public static void writeMetadataFile(String jobName, String jobId, String contai
       MetricsHeader metricsHeader =
           new MetricsHeader(jobName, jobId, "samza-container-" + containerId, execEnvContainerId.orElse(""),
               LocalContainerRunner.class.getName(), Util.getTaskClassVersion(config), Util.getSamzaVersion(),
-              Util.getLocalHost().getHostName(), System.currentTimeMillis(), System.currentTimeMillis());
+              Util.getLocalHost().getHostName(), System.currentTimeMillis(), System.currentTimeMillis(), config);

Review comment:
       Removed the config from the MetricsHeader.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org