You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by fh...@apache.org on 2008/01/03 04:27:07 UTC
svn commit: r608329 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: fhanik
Date: Wed Jan 2 19:27:06 2008
New Revision: 608329
URL: http://svn.apache.org/viewvc?rev=608329&view=rev
Log:
cast vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=608329&r1=608328&r2=608329&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Jan 2 19:27:06 2008
@@ -53,7 +53,7 @@
http://svn.apache.org/viewvc?rev=607596&view=rev
http://svn.apache.org/viewvc?rev=607597&view=rev
+1: markt, funkman
- -1:
+ -1: fhanik - lets not do e.printStackTrace, handle the error and log it correctly, also, have the diff only change lines that are actually changed. makes it easier to review
* Improve Jasper docs. Note rather than remove unused option, it will be
deprecated in 6.0.x.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r608329 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
Filip Hanik - Dev Lists wrote:
> Mark Thomas wrote:
>> fhanik@apache.org wrote:
>>
>>> + -1: fhanik - lets not do e.printStackTrace, handle the error and
>>> log it correctly,
>>>
>>
>> Fair point. I'll fix that.
>>
>> also, have the diff only change lines that are actually changed. makes it
>> easier to review
>>
>> Which lines do you mean? The diff looks normal to me.
>>
> pretty much all the lines before
> "public class SerializablePrincipal" are non functional changes, but
> cosmetic.
Got it. I didn't realise you meant "not cosmetic changes" when you wrote
"actually changed"
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r608329 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
Mark Thomas wrote:
> fhanik@apache.org wrote:
>
>> + -1: fhanik - lets not do e.printStackTrace, handle the error and log it correctly,
>>
>
> Fair point. I'll fix that.
>
> also, have the diff only change lines that are actually changed. makes it
> easier to review
>
> Which lines do you mean? The diff looks normal to me.
>
pretty much all the lines before
"public class SerializablePrincipal" are non functional changes, but
cosmetic.
and
- public SerializablePrincipal()
- {
+ public SerializablePrincipal() {
super();
}
+
+
and so on
Filip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r608329 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Filip Hanik - Dev Lists <de...@hanik.com>.
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/SerializablePrincipal.java?r1=607596&r2=607595&pathrev=607596
Mark Thomas wrote:
> fhanik@apache.org wrote:
>
>> + -1: fhanik - lets not do e.printStackTrace, handle the error and log it correctly,
>>
>
> Fair point. I'll fix that.
>
> also, have the diff only change lines that are actually changed. makes it
> easier to review
>
> Which lines do you mean? The diff looks normal to me.
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r608329 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
fhanik@apache.org wrote:
> + -1: fhanik - lets not do e.printStackTrace, handle the error and log it correctly,
Fair point. I'll fix that.
also, have the diff only change lines that are actually changed. makes it
easier to review
Which lines do you mean? The diff looks normal to me.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org