You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/08/03 16:54:47 UTC
[GitHub] [brooklyn-ui] algairim opened a new pull request #258: Display icon in DSL editor search result only if there is one
algairim opened a new pull request #258:
URL: https://github.com/apache/brooklyn-ui/pull/258
Signed-off-by: Mykola Mandra <my...@cloudsoft.io>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #258: Display icon in DSL editor search result only if there is one
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #258:
URL: https://github.com/apache/brooklyn-ui/pull/258#discussion_r681939126
##########
File path: ui-modules/blueprint-composer/app/components/dsl-editor/dsl-editor.template.html
##########
@@ -62,7 +62,7 @@ <h4 class="list-group-item-heading">
{{item.name}}
</h4>
<p class="list-group-item-entity text-right text-muted">
- <img ng-src="{{item.entity.icon}}" alt="{{item.entity.miscData.get('typeName') || (item.entity | entityName) || 'New application'}} logo" class="list-group-item-entity-icon" />
+ <img ng-if="item.entity.icon" ng-src="{{item.entity.icon}}" class="list-group-item-entity-icon"/>
Review comment:
@ahgittin, this is a proposal to resolve icon issue in DSL search result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana merged pull request #258: Display icon in DSL editor search result only if there is one
Posted by GitBox <gi...@apache.org>.
iuliana merged pull request #258:
URL: https://github.com/apache/brooklyn-ui/pull/258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #258: Display icon in DSL editor search result only if there is one
Posted by GitBox <gi...@apache.org>.
ahgittin commented on a change in pull request #258:
URL: https://github.com/apache/brooklyn-ui/pull/258#discussion_r682380163
##########
File path: ui-modules/blueprint-composer/app/components/dsl-editor/dsl-editor.template.html
##########
@@ -62,7 +62,7 @@ <h4 class="list-group-item-heading">
{{item.name}}
</h4>
<p class="list-group-item-entity text-right text-muted">
- <img ng-src="{{item.entity.icon}}" alt="{{item.entity.miscData.get('typeName') || (item.entity | entityName) || 'New application'}} logo" class="list-group-item-entity-icon" />
+ <img ng-if="item.entity.icon" ng-src="{{item.entity.icon}}" class="list-group-item-entity-icon"/>
Review comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] iuliana commented on a change in pull request #258: Display icon in DSL editor search result only if there is one
Posted by GitBox <gi...@apache.org>.
iuliana commented on a change in pull request #258:
URL: https://github.com/apache/brooklyn-ui/pull/258#discussion_r682379145
##########
File path: ui-modules/blueprint-composer/app/components/dsl-editor/dsl-editor.template.html
##########
@@ -62,7 +62,7 @@ <h4 class="list-group-item-heading">
{{item.name}}
</h4>
<p class="list-group-item-entity text-right text-muted">
- <img ng-src="{{item.entity.icon}}" alt="{{item.entity.miscData.get('typeName') || (item.entity | entityName) || 'New application'}} logo" class="list-group-item-entity-icon" />
+ <img ng-if="item.entity.icon" ng-src="{{item.entity.icon}}" class="list-group-item-entity-icon"/>
Review comment:
This looks a lot cleaner. I like it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org