[jira] [Resolved] (IMPALA-3551) Fix ThriftClient initialization code

["Tim Armstrong (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Armstrong resolved IMPALA-3551.
-----------------------------------
    Resolution: Won't Fix

I think the current pattern where Open()/OpenWithRetry() checks init_status_ is OK and it's not really that important to clean it up.

> Fix ThriftClient initialization code
> ------------------------------------
>
>                 Key: IMPALA-3551
>                 URL: https://issues.apache.org/jira/browse/IMPALA-3551
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Distributed Exec
>    Affects Versions: Impala 2.3.0, Impala 2.5.0, Impala 2.4.0, Impala 2.6.0
>            Reporter: Matthew Jacobs
>            Assignee: Tim Armstrong
>            Priority: Major
>              Labels: kerberos, ramp-up, rpc, thrift
>
> The ThriftClient constructor has a few issues:
> * All errors need to be handled. The result of {{auth_provider_->WrapClientTransport()}} is ignored.
> * Logic that can fail should be moved to an initialization method. Calling code would need to be updated.
> * Failure conditions should be tested. Right now we don't have confidence in making the above changes.
> This came up in the context of fixing IMPALA-1928, which had to be addressed in a minimal way since we don't have enough test coverage. See this review for some more context: http://gerrit.cloudera.org:8080/#/c/3093/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)