You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2008/08/22 08:18:44 UTC

[jira] Created: (SLING-626) Potential encoding issues in Sling

Potential encoding issues in Sling
----------------------------------

                 Key: SLING-626
                 URL: https://issues.apache.org/jira/browse/SLING-626
             Project: Sling
          Issue Type: Bug
          Components: Engine
            Reporter: Felix Meschberger


Jürg Meier reported encoding issues when using Sling with URL encoded POST parameters [1]. This happens regardless of the client being used (IE, Firefox) with the Sling Engine version contained in Day's CRX Quickstart 1.4.0 product [2].

The JSP script from the intiial mail (with the FormEncoding field fixed to _charset_):

-----------------------------------------------------
<?xml version="1.0" encoding="UTF-8" ?>
<%@ page language="java" contentType="text/html; charset=UTF-8"   pageEncoding="UTF-8"%>
<%@page import="javax.jcr.query.*, javax.jcr.*,
org.apache.sling.api.resource.Resource"%>
<%@page session="false"%>
<%@taglib prefix="sling"
uri="http://sling.apache.org/taglibs/sling/1.0"%>
<sling:defineObjects/>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
<title>Insert title here</title>
</head>
<body>
	<form name="form1" method="post" action="<%= currentNode.getPath()%>"
	<table width="80%" border="0" cellspacing="4" cellpadding="4">
	<tr> 
		<td>Titel:</td>
		<td><input name="title" type="text" id="title" size="80" maxlength="128" value="<%= currentNode.getProperty("title").getString()%>"></td>
	</tr>
	<tr>
		<td><input name="_charset_" type="hidden" value="UTF-8"/> </td>
		<td><input type="submit" value="Ändern"></td>
	</tr>
	</table>
	</form>
</body>
</html>


And here is the original data sent by the browser upon submitting this form:
     POSTDATA=title=Hilfe+bei+Wetterf%C3%BChligkeit&_charset_=UTF-8


It should be investigated which Engine version is being used in the CRX Quickstart and whether there have been any fixes applied after the production of that package.


[1] http://markmail.org/message/vh5sf5eoqmgs2h3r
[2] http://dev.day.com/microsling/content/blogs/cup/rules.c.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SLING-626) Potential encoding issues in Sling

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed SLING-626.
-----------------------------------

    Resolution: Cannot Reproduce
      Assignee: Felix Meschberger

Quick testing reveals that this encoding issue does not happen in the current version (trunk) any more. A new release of the engine bundle is to be created soon.

> Potential encoding issues in Sling
> ----------------------------------
>
>                 Key: SLING-626
>                 URL: https://issues.apache.org/jira/browse/SLING-626
>             Project: Sling
>          Issue Type: Bug
>          Components: Engine
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>
> Jürg Meier reported encoding issues when using Sling with URL encoded POST parameters [1]. This happens regardless of the client being used (IE, Firefox) with the Sling Engine version contained in Day's CRX Quickstart 1.4.0 product [2].
> The JSP script from the intiial mail (with the FormEncoding field fixed to _charset_):
> -----------------------------------------------------
> <?xml version="1.0" encoding="UTF-8" ?>
> <%@ page language="java" contentType="text/html; charset=UTF-8"   pageEncoding="UTF-8"%>
> <%@page import="javax.jcr.query.*, javax.jcr.*,
> org.apache.sling.api.resource.Resource"%>
> <%@page session="false"%>
> <%@taglib prefix="sling"
> uri="http://sling.apache.org/taglibs/sling/1.0"%>
> <sling:defineObjects/>
> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
> "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> <html xmlns="http://www.w3.org/1999/xhtml">
> <head>
> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
> <title>Insert title here</title>
> </head>
> <body>
> 	<form name="form1" method="post" action="<%= currentNode.getPath()%>"
> 	<table width="80%" border="0" cellspacing="4" cellpadding="4">
> 	<tr> 
> 		<td>Titel:</td>
> 		<td><input name="title" type="text" id="title" size="80" maxlength="128" value="<%= currentNode.getProperty("title").getString()%>"></td>
> 	</tr>
> 	<tr>
> 		<td><input name="_charset_" type="hidden" value="UTF-8"/> </td>
> 		<td><input type="submit" value="Ändern"></td>
> 	</tr>
> 	</table>
> 	</form>
> </body>
> </html>
> And here is the original data sent by the browser upon submitting this form:
>      POSTDATA=title=Hilfe+bei+Wetterf%C3%BChligkeit&_charset_=UTF-8
> It should be investigated which Engine version is being used in the CRX Quickstart and whether there have been any fixes applied after the production of that package.
> [1] http://markmail.org/message/vh5sf5eoqmgs2h3r
> [2] http://dev.day.com/microsling/content/blogs/cup/rules.c.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.