You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ap...@apache.org on 2019/02/28 12:27:30 UTC

[arrow] branch master updated: ARROW-4712: [C++][CI] fix build (sum.cc) has warnings in clang

This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new d9a8dc6  ARROW-4712: [C++][CI] fix build (sum.cc) has warnings in clang
d9a8dc6 is described below

commit d9a8dc624a4a459d6124f8cd3603b8bb4540ada9
Author: Micah Kornfield <em...@gmail.com>
AuthorDate: Thu Feb 28 13:27:20 2019 +0100

    ARROW-4712: [C++][CI] fix build (sum.cc) has warnings in clang
    
    Author: Micah Kornfield <em...@gmail.com>
    Author: Antoine Pitrou <an...@python.org>
    Author: emkornfield <em...@gmail.com>
    
    Closes #3778 from emkornfield/fix_build and squashes the following commits:
    
    9eee6806e <Antoine Pitrou> Fix lint
    f63d05237 <emkornfield> Update sum.cc
    0b9d5091c <Micah Kornfield> remove one move
    4c809221e <Micah Kornfield> fix build
---
 cpp/src/arrow/compute/kernels/sum.cc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/cpp/src/arrow/compute/kernels/sum.cc b/cpp/src/arrow/compute/kernels/sum.cc
index 14b999c..25d245d 100644
--- a/cpp/src/arrow/compute/kernels/sum.cc
+++ b/cpp/src/arrow/compute/kernels/sum.cc
@@ -15,8 +15,10 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include "arrow/compute/kernels/sum.h"
+#include <utility>
+
 #include "arrow/compute/kernels/sum-internal.h"
+#include "arrow/compute/kernels/sum.h"
 
 namespace arrow {
 namespace compute {
@@ -46,7 +48,7 @@ struct SumState {
       boxed->is_valid = false;
     }
 
-    return boxed;
+    return std::move(boxed);
   }
 
   static std::shared_ptr<DataType> out_type() {