You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/07 20:07:59 UTC
[GitHub] [airflow] ryanahamilton opened a new pull request #8182: Consistent
formatting in CSS files
ryanahamilton opened a new pull request #8182: Consistent formatting in CSS files
URL: https://github.com/apache/airflow/pull/8182
Cleans up the CSS formatting across Webserver CSS files (excluding `bootstrap-theme.css`) and a handful of inline styles. I've only modified format—none of the changes should bear any impact on what is rendered. While formatting styles can become rather subjective, I attempted to limit to mostly objective changes, including:
- Consistent CSS indentation (as suggested by the [`.editorconfig` rule](https://github.com/apache/airflow/blob/48e89bd51c356cf0ce92563d10f4aadf6eb3a0ac/.editorconfig#L39-L40))
- Consistent spacing, line-breaks, ending semi-colons
- Short-hand, lowercase hex color values
- Removed units from `0` values
- Updated to newer `::` syntax for pseudo elements
- Removed vendor prefixes for long, widely-supported CSS features
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ryanahamilton commented on issue #8182: Consistent
formatting in CSS files
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on issue #8182: Consistent formatting in CSS files
URL: https://github.com/apache/airflow/pull/8182#issuecomment-610693185
@mik-laj I'd like to follow-up this PR with another to add a linter (likely [stylelint](https://stylelint.io/)) that we can add to the pre-commit. I'll address remaining violations to get it in a passing state as well. Does that plan work for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8182: Consistent formatting in
CSS files
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8182: Consistent formatting in CSS files
URL: https://github.com/apache/airflow/pull/8182#issuecomment-610880912
CI failure is unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #8182: Consistent formatting in
CSS files
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #8182: Consistent formatting in CSS files
URL: https://github.com/apache/airflow/pull/8182#issuecomment-610605097
@mik-laj Yup, just discussing that now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #8182: Consistent formatting
in CSS files
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8182: Consistent formatting in CSS files
URL: https://github.com/apache/airflow/pull/8182#issuecomment-610710464
@ryanahamilton That sounds fantastic. I'm waiting. Web UI needs a lot of our love
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil removed a comment on issue #8182: Consistent
formatting in CSS files
Posted by GitBox <gi...@apache.org>.
kaxil removed a comment on issue #8182: Consistent formatting in CSS files
URL: https://github.com/apache/airflow/pull/8182#issuecomment-610880912
CI failure is unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb merged pull request #8182: Consistent formatting in
CSS files
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #8182: Consistent formatting in CSS files
URL: https://github.com/apache/airflow/pull/8182
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #8182: Consistent formatting
in CSS files
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #8182: Consistent formatting in CSS files
URL: https://github.com/apache/airflow/pull/8182#issuecomment-610603919
How will we prevent regression? Did you think to use an automatic tool and add it to the pre-commit?https://github.com/apache/airflow/blob/master/.pre-commit-config.yaml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #8182: Consistent
formatting in CSS files
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #8182: Consistent formatting in CSS files
URL: https://github.com/apache/airflow/pull/8182#issuecomment-610879191
# [Codecov](https://codecov.io/gh/apache/airflow/pull/8182?src=pr&el=h1) Report
> Merging [#8182](https://codecov.io/gh/apache/airflow/pull/8182?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5576f71c8b99621b6e7b4517f5cea196e0163d81&el=desc) will **increase** coverage by `27.76%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/airflow/pull/8182?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8182 +/- ##
===========================================
+ Coverage 60.55% 88.32% +27.76%
===========================================
Files 935 935
Lines 45170 45243 +73
===========================================
+ Hits 27353 39959 +12606
+ Misses 17817 5284 -12533
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/8182?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `91.65% <ø> (-0.04%)` | :arrow_down: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.94% <ø> (+4.89%)` | :arrow_up: |
| [airflow/models/dagcode.py](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnY29kZS5weQ==) | `95.74% <33.33%> (+3.27%)` | :arrow_up: |
| [airflow/models/taskinstance.py](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvdGFza2luc3RhbmNlLnB5) | `94.70% <100.00%> (ø)` | |
| [airflow/providers/google/cloud/hooks/datafusion.py](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2hvb2tzL2RhdGFmdXNpb24ucHk=) | `81.30% <100.00%> (+47.66%)` | :arrow_up: |
| [...low/providers/google/cloud/operators/datafusion.py](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9kYXRhZnVzaW9uLnB5) | `97.56% <100.00%> (+27.95%)` | :arrow_up: |
| [airflow/www/utils.py](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdXRpbHMucHk=) | `80.85% <100.00%> (ø)` | |
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.67% <100.00%> (+0.14%)` | :arrow_up: |
| [airflow/exceptions.py](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGNlcHRpb25zLnB5) | `100.00% <0.00%> (ø)` | |
| ... and [335 more](https://codecov.io/gh/apache/airflow/pull/8182/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/8182?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/8182?src=pr&el=footer). Last update [88e756e...371b468](https://codecov.io/gh/apache/airflow/pull/8182?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services