[GitHub] [pinot] npawar commented on a diff in pull request #9020: Null check for partitionGroupSmallestOffset and metric for failure in RealtimeSegmentValidationManager

[GitBox <gi...@apache.org>]

npawar commented on code in PR #9020:
URL: https://github.com/apache/pinot/pull/9020#discussion_r914317759


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1215,12 +1215,18 @@ private void createNewConsumingSegment(TableConfig tableConfig, PartitionLevelSt
     StreamPartitionMsgOffset partitionGroupSmallestOffset =
         getPartitionGroupSmallestOffset(streamConfig, partitionGroupId);
 
-    // Start offset must be higher than the start offset of the stream
-    if (partitionGroupSmallestOffset.compareTo(startOffset) > 0) {
-      LOGGER.error("Data lost from offset: {} to: {} for partition: {} of table: {}", startOffset,
-          partitionGroupSmallestOffset, partitionGroupId, tableConfig.getTableName());
+    if (partitionGroupSmallestOffset != null) {
+      // Start offset must be higher than the start offset of the stream
+      if (partitionGroupSmallestOffset.compareTo(startOffset) > 0) {

Review Comment:
   correct. that's coming from the startOffset value set in segmentZkMetadata



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org