[GitHub] [arrow] paleolimbot commented on pull request #34013: GH-33960: [C++] Add DeclarationToSchema and DeclarationToString helper methods.

["paleolimbot (via GitHub)" <gi...@apache.org>]

paleolimbot commented on PR #34013:
URL: https://github.com/apache/arrow/pull/34013#issuecomment-1414695012

   I should have done a search for "Declaration" before somewhat approving this approach 😬 
   
   I think this *would* close #33960 if we were constructing our plan in a non-deprecated way:
   
   https://github.com/apache/arrow/blob/2ad89525173bbe3e03814eb4310b6e58fad5b989/r/src/compute-exec.cpp#L44-L46
   
   Since I don't see any declarations in our plan-building process, I'm not sure we can avoid building an entire exec plan to get the schema.
   
   It does help us with our Substrait schema calculation, though, since presumably we could add a substrait-plan-in-schema-out method.
   
   https://github.com/apache/arrow/blob/2ad89525173bbe3e03814eb4310b6e58fad5b989/r/src/compute-exec.cpp#L530-L532


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org