You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/22 06:27:49 UTC

[GitHub] [tvm] sfvaroglu opened a new pull request, #12869: [ONNX] Fix test_roi_align failure

sfvaroglu opened a new pull request, #12869:
URL: https://github.com/apache/tvm/pull/12869

   RoiAlign-16 introduces `coordinate_transformation_mode`, which should be set to 'output_half_pixel' to omit the pixel shift for the input (for a backward-compatible behavior). This PR should fix the failure in https://ci.tlcpack.ai/job/docker-images-ci/job/docker-image-run-tests/231/testReport/junit/cython.tests.python.frontend.onnx/test_forward/Test___frontend__GPU_3_of_6___test_roi_align_cuda_/ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] sfvaroglu commented on pull request #12869: [ONNX] Fix test_roi_align failure

Posted by GitBox <gi...@apache.org>.
sfvaroglu commented on PR #12869:
URL: https://github.com/apache/tvm/pull/12869#issuecomment-1254585495

   @leandron @driazati 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] driazati commented on pull request #12869: [ONNX] Fix test_roi_align failure

Posted by GitBox <gi...@apache.org>.
driazati commented on PR #12869:
URL: https://github.com/apache/tvm/pull/12869#issuecomment-1258303312

   Since we need to update the image to fix the test and fix the test to update the image, https://github.com/apache/tvm/tree/sevin/test_roi_align_fix rolls them all into one (CI jobs that run against branches in apache/tvm will use the newly specified images). #12906 passed the branch CI and hopefully will pass the other so we can merge that one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] sfvaroglu commented on pull request #12869: [ONNX] Fix test_roi_align failure

Posted by GitBox <gi...@apache.org>.
sfvaroglu commented on PR #12869:
URL: https://github.com/apache/tvm/pull/12869#issuecomment-1254710003

   The roi_align test passes locally when using `onnx==1.12.0` and `onnxruntime==1.12.1`, but it looks like CI is failing with `onnxruntime.capi.onnxruntime_pybind11_state.InvalidGraph: [ONNXRuntimeError] : 10 : INVALID_GRAPH : This is an invalid model. Error in Node: : Unrecognized attribute: coordinate_transformation_mode for operator RoiAlign` which means the CI image doesn't have the updated onnx and onnxruntime, but the CI image at https://ci.tlcpack.ai/job/docker-images-ci/job/docker-image-run-tests/231/testReport/junit/cython.tests.python.frontend.onnx/test_forward/Test___frontend__GPU_3_of_6___test_roi_align_cuda_/ has the updated onnx and onnxruntime and fails with a different error.
   
   What do we need to update the CI image this PR is running on? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org