You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ch...@apache.org on 2012/11/29 18:30:28 UTC
git commit: CLOUDSTACK-505: Do not log the command response object
for the createSSHKeyPair command. Signed-off-by: Chip Childers
Updated Branches:
refs/heads/master 46b16e591 -> e4a517319
CLOUDSTACK-505: Do not log the command response object for the createSSHKeyPair command.
Signed-off-by: Chip Childers <ch...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/e4a51731
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/e4a51731
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/e4a51731
Branch: refs/heads/master
Commit: e4a51731990c7599f92e00cd286d6ae760a98ed4
Parents: 46b16e5
Author: Chip Childers <ch...@gmail.com>
Authored: Thu Nov 29 12:24:42 2012 -0500
Committer: Chip Childers <ch...@gmail.com>
Committed: Thu Nov 29 12:24:42 2012 -0500
----------------------------------------------------------------------
server/src/com/cloud/api/ApiServer.java | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/blob/e4a51731/server/src/com/cloud/api/ApiServer.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/api/ApiServer.java b/server/src/com/cloud/api/ApiServer.java
index a5c9ea5..7365b36 100755
--- a/server/src/com/cloud/api/ApiServer.java
+++ b/server/src/com/cloud/api/ApiServer.java
@@ -586,7 +586,11 @@ public class ApiServer implements HttpRequestHandler {
return;
}
auditTrailSb.append(" " + HttpServletResponse.SC_OK + " ");
- auditTrailSb.append(result);
+ if (command.equals("createSSHKeyPair")){
+ auditTrailSb.append("This result was not logged because it contains sensitive data.");
+ } else {
+ auditTrailSb.append(result);
+ }
/*
* if (command.equals("queryAsyncJobResult")){ //For this command we need to also log job status and job
* resultcode for