You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/06/10 01:27:23 UTC
[GitHub] [pinot] shenyu0127 opened a new pull request, #10887: Fix a bug in SELECT DISTINCT ORDER BY LIMIT.
shenyu0127 opened a new pull request, #10887:
URL: https://github.com/apache/pinot/pull/10887
Currently we might incorrectly include NULL in the `SELECT DISTINCT ORDRE BY LIMIT` query result.
Tested in unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10887: Fix a bug in SELECT DISTINCT ORDER BY LIMIT.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10887:
URL: https://github.com/apache/pinot/pull/10887#issuecomment-1585424873
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10887](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (93ec4be) into [master](https://app.codecov.io/gh/apache/pinot/commit/b1e8655449abd903330993370dee2541869f8be9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b1e8655) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #10887 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2186 2132 -54
Lines 117241 114738 -2503
Branches 17699 17398 -301
=========================================
Hits 137 137
+ Misses 117084 114581 -2503
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests2temurin11 | `0.11% <0.00%> (ø)` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...raw/BaseRawDoubleSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0RvdWJsZVNpbmdsZUNvbHVtbkRpc3RpbmN0RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../raw/BaseRawFloatSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0Zsb2F0U2luZ2xlQ29sdW1uRGlzdGluY3RFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ct/raw/BaseRawIntSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0ludFNpbmdsZUNvbHVtbkRpc3RpbmN0RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/raw/BaseRawLongSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0xvbmdTaW5nbGVDb2x1bW5EaXN0aW5jdEV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...raw/RawDoubleSingleColumnDistinctOnlyExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3RG91YmxlU2luZ2xlQ29sdW1uRGlzdGluY3RPbmx5RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../RawDoubleSingleColumnDistinctOrderByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3RG91YmxlU2luZ2xlQ29sdW1uRGlzdGluY3RPcmRlckJ5RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../raw/RawFloatSingleColumnDistinctOnlyExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3RmxvYXRTaW5nbGVDb2x1bW5EaXN0aW5jdE9ubHlFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...w/RawFloatSingleColumnDistinctOrderByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3RmxvYXRTaW5nbGVDb2x1bW5EaXN0aW5jdE9yZGVyQnlFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ct/raw/RawIntSingleColumnDistinctOnlyExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3SW50U2luZ2xlQ29sdW1uRGlzdGluY3RPbmx5RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...raw/RawIntSingleColumnDistinctOrderByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3SW50U2luZ2xlQ29sdW1uRGlzdGluY3RPcmRlckJ5RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| ... and [2 more](https://app.codecov.io/gh/apache/pinot/pull/10887?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [56 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10887/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10887: Fix a bug in SELECT DISTINCT ORDER BY LIMIT.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10887:
URL: https://github.com/apache/pinot/pull/10887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org