[jira] [Updated] (BCEL-138) FieldInstruction.getFieldSize() doesn't decode Type.getTypeSize() output

["Emmanuel Bourg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BCEL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Bourg updated BCEL-138:
--------------------------------

         Priority: Blocker
      Environment:     (was: Operating System: Windows XP
Platform: PC)
    Fix Version/s: 6.0

> FieldInstruction.getFieldSize() doesn't decode Type.getTypeSize() output
> ------------------------------------------------------------------------
>
>                 Key: BCEL-138
>                 URL: https://issues.apache.org/jira/browse/BCEL-138
>             Project: Commons BCEL
>          Issue Type: Bug
>          Components: Main
>    Affects Versions: unspecified
>            Reporter: Enrico Gueli
>            Assignee: Apache Commons Developers
>            Priority: Blocker
>             Fix For: 6.0
>
>         Attachments: patch.txt
>
>
> The method getTypeSize(String) in the Type class returns two outputs encoded in one integer: the lowest two bits contain the field size (0, 1 or 2), the remaining ones the no. of consumed characters in the signature. Type provides two private static methods, size() and consumed(), to split these values apart.
> The method getFieldSize(ConstantPoolGen) in the FieldInstrucion class uses Type.getTypeSize, unaware that the output is encoded. Therefore, the returned size is different than expected. This causes, among other things, a bigger or smaller max stack depth value for generated methods that leads to unused stack memory or a "java.lang.VerifyError: stack size too large" exception, respectively.
> A fix can be made by making the above-mentioned static methods package-visible and modifying getFieldSize() to use them.



--
This message was sent by Atlassian JIRA
(v6.2#6252)