You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by de...@geronimo.apache.org on 2004/09/10 02:22:37 UTC

[jira] Created: (GERONIMO-290) static content with spaces in path or name can't be deployed

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/GERONIMO-290

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: GERONIMO-290
    Summary: static content with spaces in path or name can't be deployed
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Apache Geronimo
 Components: 
             web
   Versions:
             1.0-M2

   Assignee: 
   Reporter: David Jencks

    Created: Thu, 9 Sep 2004 5:20 PM
    Updated: Thu, 9 Sep 2004 5:20 PM

Description:
1. Contruct a war file containing static content where a file name has a space in its name.
2. add appropriate web.xml, geronimo-jetty.xml

Deploying such a war file results in an IllegalArgumentException from this attempt to resolve an illegal uri:

(JettyModuleBuilder, around line 660)
        public void installInEARContext(EARContext earContext, URI moduleBase) throws DeploymentException, IOException {
            JarInputStream jarIS = new JarInputStream(new FileInputStream(webAppFile.getName()));
            for (JarEntry entry; (entry = jarIS.getNextJarEntry()) != null; jarIS.closeEntry()) {
                URI target = moduleBase.resolve(entry.getName());


URI javadoc specifies that the string argument to resolve must satisfy RFC 2396, in particular no spaces.

This war deploys ok on [jboss/]tomcat 4.1.29 and the content is visible in IE with the space encoded as %20

One possible solution is to use a multi-arg URI constructor on entry.getName(), which will encode the string properly.  We will have to verify that any solution is compatible with jetty's handling of the content.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (GERONIMO-290) static content with spaces in path or name can't be deployed

Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-290?page=history ]

John Sisson updated GERONIMO-290:
---------------------------------

    Attachment: JettyModuleBuilder_patch.txt

Attached patch for review for geronimo\modules\jetty-builder\src\java\org\apache\geronimo\jetty\deployment\JettyModuleBuilder.java

> static content with spaces in path or name can't be deployed
> ------------------------------------------------------------
>
>          Key: GERONIMO-290
>          URL: http://issues.apache.org/jira/browse/GERONIMO-290
>      Project: Apache Geronimo
>         Type: Bug
>   Components: web
>     Versions: 1.0-M2
>     Reporter: David Jencks
>  Attachments: JettyModuleBuilder_patch.txt
>
> 1. Contruct a war file containing static content where a file name has a space in its name.
> 2. add appropriate web.xml, geronimo-jetty.xml
> Deploying such a war file results in an IllegalArgumentException from this attempt to resolve an illegal uri:
> (JettyModuleBuilder, around line 660)
>         public void installInEARContext(EARContext earContext, URI moduleBase) throws DeploymentException, IOException {
>             JarInputStream jarIS = new JarInputStream(new FileInputStream(webAppFile.getName()));
>             for (JarEntry entry; (entry = jarIS.getNextJarEntry()) != null; jarIS.closeEntry()) {
>                 URI target = moduleBase.resolve(entry.getName());
> URI javadoc specifies that the string argument to resolve must satisfy RFC 2396, in particular no spaces.
> This war deploys ok on [jboss/]tomcat 4.1.29 and the content is visible in IE with the space encoded as %20
> One possible solution is to use a multi-arg URI constructor on entry.getName(), which will encode the string properly.  We will have to verify that any solution is compatible with jetty's handling of the content.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (GERONIMO-290) static content with spaces in path or name can't be deployed

Posted by "John Sisson (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-290?page=comments#action_60306 ]
     
John Sisson commented on GERONIMO-290:
--------------------------------------

David Jencks, patch for you to review when you have a chance.  Thanks, John.

> static content with spaces in path or name can't be deployed
> ------------------------------------------------------------
>
>          Key: GERONIMO-290
>          URL: http://issues.apache.org/jira/browse/GERONIMO-290
>      Project: Geronimo
>         Type: Bug
>   Components: web
>     Versions: 1.0-M2
>     Reporter: David Jencks
>  Attachments: JettyModuleBuilder_patch.txt
>
> 1. Contruct a war file containing static content where a file name has a space in its name.
> 2. add appropriate web.xml, geronimo-jetty.xml
> Deploying such a war file results in an IllegalArgumentException from this attempt to resolve an illegal uri:
> (JettyModuleBuilder, around line 660)
>         public void installInEARContext(EARContext earContext, URI moduleBase) throws DeploymentException, IOException {
>             JarInputStream jarIS = new JarInputStream(new FileInputStream(webAppFile.getName()));
>             for (JarEntry entry; (entry = jarIS.getNextJarEntry()) != null; jarIS.closeEntry()) {
>                 URI target = moduleBase.resolve(entry.getName());
> URI javadoc specifies that the string argument to resolve must satisfy RFC 2396, in particular no spaces.
> This war deploys ok on [jboss/]tomcat 4.1.29 and the content is visible in IE with the space encoded as %20
> One possible solution is to use a multi-arg URI constructor on entry.getName(), which will encode the string properly.  We will have to verify that any solution is compatible with jetty's handling of the content.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Closed: (GERONIMO-290) static content with spaces in path or name can't be deployed

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-290?page=history ]
     
David Jencks closed GERONIMO-290:
---------------------------------

     Resolution: Fixed
    Fix Version: 1.0-M4

Applied, thanks!

> static content with spaces in path or name can't be deployed
> ------------------------------------------------------------
>
>          Key: GERONIMO-290
>          URL: http://issues.apache.org/jira/browse/GERONIMO-290
>      Project: Geronimo
>         Type: Bug
>   Components: web
>     Versions: 1.0-M2
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.0-M4
>  Attachments: JettyModuleBuilder_patch.txt
>
> 1. Contruct a war file containing static content where a file name has a space in its name.
> 2. add appropriate web.xml, geronimo-jetty.xml
> Deploying such a war file results in an IllegalArgumentException from this attempt to resolve an illegal uri:
> (JettyModuleBuilder, around line 660)
>         public void installInEARContext(EARContext earContext, URI moduleBase) throws DeploymentException, IOException {
>             JarInputStream jarIS = new JarInputStream(new FileInputStream(webAppFile.getName()));
>             for (JarEntry entry; (entry = jarIS.getNextJarEntry()) != null; jarIS.closeEntry()) {
>                 URI target = moduleBase.resolve(entry.getName());
> URI javadoc specifies that the string argument to resolve must satisfy RFC 2396, in particular no spaces.
> This war deploys ok on [jboss/]tomcat 4.1.29 and the content is visible in IE with the space encoded as %20
> One possible solution is to use a multi-arg URI constructor on entry.getName(), which will encode the string properly.  We will have to verify that any solution is compatible with jetty's handling of the content.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (GERONIMO-290) static content with spaces in path or name can't be deployed

Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
     [ http://issues.apache.org/jira/browse/GERONIMO-290?page=history ]

David Jencks reassigned GERONIMO-290:
-------------------------------------

    Assign To: David Jencks

> static content with spaces in path or name can't be deployed
> ------------------------------------------------------------
>
>          Key: GERONIMO-290
>          URL: http://issues.apache.org/jira/browse/GERONIMO-290
>      Project: Geronimo
>         Type: Bug
>   Components: web
>     Versions: 1.0-M2
>     Reporter: David Jencks
>     Assignee: David Jencks
>  Attachments: JettyModuleBuilder_patch.txt
>
> 1. Contruct a war file containing static content where a file name has a space in its name.
> 2. add appropriate web.xml, geronimo-jetty.xml
> Deploying such a war file results in an IllegalArgumentException from this attempt to resolve an illegal uri:
> (JettyModuleBuilder, around line 660)
>         public void installInEARContext(EARContext earContext, URI moduleBase) throws DeploymentException, IOException {
>             JarInputStream jarIS = new JarInputStream(new FileInputStream(webAppFile.getName()));
>             for (JarEntry entry; (entry = jarIS.getNextJarEntry()) != null; jarIS.closeEntry()) {
>                 URI target = moduleBase.resolve(entry.getName());
> URI javadoc specifies that the string argument to resolve must satisfy RFC 2396, in particular no spaces.
> This war deploys ok on [jboss/]tomcat 4.1.29 and the content is visible in IE with the space encoded as %20
> One possible solution is to use a multi-arg URI constructor on entry.getName(), which will encode the string properly.  We will have to verify that any solution is compatible with jetty's handling of the content.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira