You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/17 01:40:23 UTC
[GitHub] [spark] ulysses-you opened a new pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
ulysses-you opened a new pull request #30075:
URL: https://github.com/apache/spark/pull/30075
This is [#30029](https://github.com/apache/spark/pull/30029) backport for branch-2.4.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Correct the resolution of having clause.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Grouping sets construct new aggregate lost the qualified name of grouping expression. Here is a example:
```
-- Works resolved by `ResolveReferences`
select c1 from values (1) as t1(c1) group by grouping sets(t1.c1) having c1 = 1
-- Works because of the extra expression c1
select c1 as c2 from values (1) as t1(c1) group by grouping sets(t1.c1) having t1.c1 = 1
-- Failed
select c1 from values (1) as t1(c1) group by grouping sets(t1.c1) having t1.c1 = 1
```
It wroks with `Aggregate` without grouping sets through `ResolveReferences`, but Grouping sets not works since the exprId has been changed.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, bug fix.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
add test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710782228
Seems this error is not related.
```
Traceback (most recent call last):
File "/home/runner/work/spark/spark/python/pyspark/mllib/tests.py", line 1492, in test_training_and_prediction
self._eventually(condition, timeout=180.0)
File "/home/runner/work/spark/spark/python/pyspark/mllib/tests.py", line 133, in _eventually
lastValue = condition()
File "/home/runner/work/spark/spark/python/pyspark/mllib/tests.py", line 1487, in condition
self.assertGreater(errors[1] - errors[-1], 0.3)
AssertionError: -0.07000000000000006 not greater than 0.3
```
cc @viirya @HyukjinKwon can we backport [#23586](https://github.com/apache/spark/pull/23586) in branch-2.4 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710729421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711114671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710752639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710722783
**[Test build #129927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129927/testReport)** for PR 30075 at commit [`476eac9`](https://github.com/apache/spark/commit/476eac92e73aee516211e03bcaf184ffcabb617a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711130214
thanks for merging!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711105445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710726840
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34532/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710729427
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34532/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710722987
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129927/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710764288
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129937/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710722986
Build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710764286
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710752631
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34542/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710731259
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710731267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711114582
**[Test build #129951 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129951/testReport)** for PR 30075 at commit [`891d0cf`](https://github.com/apache/spark/commit/891d0cf1eb8ae5bbb598a205f5f0fb20e00b185e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710750473
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34542/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710748050
**[Test build #129937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129937/testReport)** for PR 30075 at commit [`fdb1aed`](https://github.com/apache/spark/commit/fdb1aede9f7f444d65b1e470901cba2aec7efbb0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711105445
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710731267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710727974
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710764183
**[Test build #129937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129937/testReport)** for PR 30075 at commit [`fdb1aed`](https://github.com/apache/spark/commit/fdb1aede9f7f444d65b1e470901cba2aec7efbb0).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710724052
**[Test build #129929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129929/testReport)** for PR 30075 at commit [`fa072b1`](https://github.com/apache/spark/commit/fa072b1322e6e5b06ab83475760a3bc0d7e74ec6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710743325
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129929/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710724052
**[Test build #129929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129929/testReport)** for PR 30075 at commit [`fa072b1`](https://github.com/apache/spark/commit/fa072b1322e6e5b06ab83475760a3bc0d7e74ec6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710752639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710748050
**[Test build #129937 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129937/testReport)** for PR 30075 at commit [`fdb1aed`](https://github.com/apache/spark/commit/fdb1aede9f7f444d65b1e470901cba2aec7efbb0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710764286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711105447
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34556/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711102807
**[Test build #129951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129951/testReport)** for PR 30075 at commit [`891d0cf`](https://github.com/apache/spark/commit/891d0cf1eb8ae5bbb598a205f5f0fb20e00b185e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710722783
**[Test build #129927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129927/testReport)** for PR 30075 at commit [`476eac9`](https://github.com/apache/spark/commit/476eac92e73aee516211e03bcaf184ffcabb617a).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711045636
Created #30078.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711043630
Ok, let me backport #23586 to branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710743322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710743322
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30075:
URL: https://github.com/apache/spark/pull/30075
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710722977
**[Test build #129927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129927/testReport)** for PR 30075 at commit [`476eac9`](https://github.com/apache/spark/commit/476eac92e73aee516211e03bcaf184ffcabb617a).
* This patch **fails Scala style tests**.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710723641
@dongjoon-hyun thank you, I will push branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711104250
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34556/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711114671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710729372
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34532/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710743180
**[Test build #129929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129929/testReport)** for PR 30075 at commit [`fa072b1`](https://github.com/apache/spark/commit/fa072b1322e6e5b06ab83475760a3bc0d7e74ec6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class AuthRpcHandler extends AbstractAuthRpcHandler `
* `public class SaslRpcHandler extends AbstractAuthRpcHandler `
* `public abstract class AbstractAuthRpcHandler extends RpcHandler `
* ` logDebug(s\" + cloning instance of REPL class $capturingClassName\")`
* ` // class InnerFoo `
* ` // found intra class call to $iw.$anonfun$closure$1(L$iw;I)Lscala/collection/immutable/IndexedSeq;`
* ` // found intra class call to $iw$InnerFoo$1.$anonfun$innerClosure$1(L$iw$InnerFoo$1;I)Lscala/collection/immutable/IndexedSeq;`
* ` // found intra class call to $iw$InnerFoo$1.$anonfun$innerClosure$2(L$iw$InnerFoo$1;I)Ljava/lang/String;`
* ` // found intra class call to $iw$InnerFoo$1.$anonfun$innerClosure$2(L$iw$InnerFoo$1;I)Ljava/lang/String;`
* ` // (class java.lang.Object,Set())`
* ` // (class $iw,Set(topLevelValue))`
* ` // starting closure (in class T)`
* ` // we need to track calls from \"inner closure\" to outer classes relative to it (class T, A, B)`
* ` logTrace(s\" found intra class call to $ownerExternalName.$name$desc\")`
* ` logDebug(s\" found inner class $ownerExternalName\")`
* `public class SparkAvroKeyOutputFormat extends AvroKeyOutputFormat<GenericRecord> `
* ` static class SparkRecordWriterFactory extends RecordWriterFactory<GenericRecord> `
* `case class UnresolvedHaving(`
* `case class First(child: Expression, ignoreNulls: Boolean)`
* `case class Last(child: Expression, ignoreNulls: Boolean)`
* `case class Size(child: Expression, legacySizeOfNull: Boolean)`
* ` class TimestampParser(fastDateFormat: FastDateFormat) `
* `class SQLExecutionRDD(`
* `case class ArrowEvalPython(`
* `case class BatchEvalPython(`
* `trait CreateHiveTableAsSelectBase extends DataWritingCommand `
* `case class CreateHiveTableAsSelectCommand(`
* `case class OptimizedCreateHiveTableAsSelectCommand(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710729421
Build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711105442
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34556/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-711102807
**[Test build #129951 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129951/testReport)** for PR 30075 at commit [`891d0cf`](https://github.com/apache/spark/commit/891d0cf1eb8ae5bbb598a205f5f0fb20e00b185e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30075: [SPARK-33131][SQL][2.4] Fix grouping sets with having clause can not resolve qualified col name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30075:
URL: https://github.com/apache/spark/pull/30075#issuecomment-710722986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org