[GitHub] [geode] kirklund opened pull request #2534: GEODE-2644: Improve GfshParserAutoCompletionTest assertions

["kirklund (GitHub)" <gi...@apache.org>]

Improve assertions so that failures in this test can be
diagnosed without using the IDE debugger.

This test is failing on my branch for GEODE-2644 but
the failure messages are very cryptic. This simple change
makes the assertion messages easy to understand. Since
this is valuable on develop, I'd like to merge the test change
to develop.

[ Full content available at: https://github.com/apache/geode/pull/2534 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #2534: GEODE-2644: Improve GfshParserAutoCompletionTest assertions

["kirklund (GitHub)" <gi...@apache.org>]

Oops. Thanks for catching that. I cherry-picked and missed it.

[ Full content available at: https://github.com/apache/geode/pull/2534 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #2534: GEODE-2644: Improve GfshParserAutoCompletionTest assertions

["kirklund (GitHub)" <gi...@apache.org>]

I also fixed warnings and replaced \n with LINE_SEPARATOR.

[ Full content available at: https://github.com/apache/geode/pull/2534 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #2534: GEODE-2644: Improve GfshParserAutoCompletionTest assertions

["kirklund (GitHub)" <gi...@apache.org>]

[ pull request closed by kirklund ]

[ Full content available at: https://github.com/apache/geode/pull/2534 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #2534: GEODE-2644: Improve GfshParserAutoCompletionTest assertions

["kirklund (GitHub)" <gi...@apache.org>]

Fixed and pushed.

[ Full content available at: https://github.com/apache/geode/pull/2534 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on pull request #2534: GEODE-2644: Improve GfshParserAutoCompletionTest assertions

["pdxrunner (GitHub)" <gi...@apache.org>]

Was this an intentional change (8 changed to 10)? Now looks like it's a hard failure.

[ Full content available at: https://github.com/apache/geode/pull/2534 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org