You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/14 09:18:34 UTC
[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #3947: [Feature][shade][Jackson] Add seatunnel-seatunnel module
TyrantLucifer opened a new pull request, #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
close #3936
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071861889
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar
scala-library-2.11.12.jar
seatunnel-config-base-2.1.1.jar
seatunnel-config-shade-2.1.1.jar
+seatunnel-jackson-2.3.1-SNAPSHOT-optional.jar
Review Comment:
If we didn't add this，CI will not be passed. Do you have any another advice？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#issuecomment-1384948836
> should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048
Yup, all shade dependencies shoule be moved to this repository. But before the shade repository released, main repository can not add shade dependency in pom file. In oreder to not block the progress of support check logic, so I temporary add it in main repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#issuecomment-1384853761
@EricJoy2048 @ashulin PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#issuecomment-1384957045
> should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048↳
waiting for the first release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071674542
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/OptionRule.java:
##########
@@ -195,8 +195,9 @@ public <T> Builder conditional(@NonNull Option<T> conditionalOption, @NonNull Li
public <T> Builder conditional(@NonNull Option<T> conditionalOption, @NonNull T expectValue, @NonNull Option<?>... requiredOptions) {
for (Option<?> o : requiredOptions) {
- verifyDuplicate(o, "ConditionalOption");
Review Comment:
IMO, submit a new PR to deal with this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071863246
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar
scala-library-2.11.12.jar
seatunnel-config-base-2.1.1.jar
seatunnel-config-shade-2.1.1.jar
+seatunnel-jackson-2.3.1-SNAPSHOT-optional.jar
Review Comment:
i will take a look later:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071676286
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/OptionRule.java:
##########
@@ -195,8 +195,9 @@ public <T> Builder conditional(@NonNull Option<T> conditionalOption, @NonNull Li
public <T> Builder conditional(@NonNull Option<T> conditionalOption, @NonNull T expectValue, @NonNull Option<?>... requiredOptions) {
for (Option<?> o : requiredOptions) {
- verifyDuplicate(o, "ConditionalOption");
Review Comment:
Yup, you are right, I had submitted another pull request #3962 to solve this problem. Temporary I rebase that onto this branch to test CI process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#issuecomment-1384945250
should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071860519
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar
scala-library-2.11.12.jar
seatunnel-config-base-2.1.1.jar
seatunnel-config-shade-2.1.1.jar
+seatunnel-jackson-2.3.1-SNAPSHOT-optional.jar
Review Comment:
we shouldn't add this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
TyrantLucifer merged PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #3947:
URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071861889
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar
scala-library-2.11.12.jar
seatunnel-config-base-2.1.1.jar
seatunnel-config-shade-2.1.1.jar
+seatunnel-jackson-2.3.1-SNAPSHOT-optional.jar
Review Comment:
If we didn't add this，CI will not be passed. Do you have any good advice？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org