You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/29 08:44:33 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
HuangXingBo opened a new pull request #14803:
URL: https://github.com/apache/flink/pull/14803
## What is the purpose of the change
*This pull request will introduce InternalTimerService In PyFlink*
## Brief change log
- *Introduce `InternalTimerService`*
## Verifying this change
This change added tests and can be verified as follows:
- *`InternalTimerServiceImpl` won't be used currently, and the related tests will be added in the PR of python general group window agg operation*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769672719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646",
"triggerID" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"triggerType" : "PUSH"
}, {
"hash" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13693",
"triggerID" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"triggerType" : "PUSH"
}, {
"hash" : "7652b98ec44266ec1f293990c1e0818589c58412",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7652b98ec44266ec1f293990c1e0818589c58412",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4e515feeaf75da0a3e403aa70fb19dace001f952 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13693)
* 7652b98ec44266ec1f293990c1e0818589c58412 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769672719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646",
"triggerID" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"triggerType" : "PUSH"
}, {
"hash" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13693",
"triggerID" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"triggerType" : "PUSH"
}, {
"hash" : "7652b98ec44266ec1f293990c1e0818589c58412",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13826",
"triggerID" : "7652b98ec44266ec1f293990c1e0818589c58412",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4e515feeaf75da0a3e403aa70fb19dace001f952 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13693)
* 7652b98ec44266ec1f293990c1e0818589c58412 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13826)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769672719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f428edbc7356fefc94bf79710c205a9609343d2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769672719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646",
"triggerID" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"triggerType" : "PUSH"
}, {
"hash" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13693",
"triggerID" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"triggerType" : "PUSH"
}, {
"hash" : "7652b98ec44266ec1f293990c1e0818589c58412",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13826",
"triggerID" : "7652b98ec44266ec1f293990c1e0818589c58412",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7652b98ec44266ec1f293990c1e0818589c58412 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13826)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo closed pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
HuangXingBo closed pull request #14803:
URL: https://github.com/apache/flink/pull/14803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769672719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646",
"triggerID" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"triggerType" : "PUSH"
}, {
"hash" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f428edbc7356fefc94bf79710c205a9609343d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646)
* 4e515feeaf75da0a3e403aa70fb19dace001f952 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769666966
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8f428edbc7356fefc94bf79710c205a9609343d2 (Fri Jan 29 08:47:42 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21199).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769672719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646",
"triggerID" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f428edbc7356fefc94bf79710c205a9609343d2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769672719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646",
"triggerID" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"triggerType" : "PUSH"
}, {
"hash" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13693",
"triggerID" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f428edbc7356fefc94bf79710c205a9609343d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646)
* 4e515feeaf75da0a3e403aa70fb19dace001f952 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13693)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769672719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646",
"triggerID" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8f428edbc7356fefc94bf79710c205a9609343d2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14803: [FLINK-21199][python] Introduce InternalTimerService In PyFlink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14803:
URL: https://github.com/apache/flink/pull/14803#issuecomment-769672719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12646",
"triggerID" : "8f428edbc7356fefc94bf79710c205a9609343d2",
"triggerType" : "PUSH"
}, {
"hash" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13693",
"triggerID" : "4e515feeaf75da0a3e403aa70fb19dace001f952",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4e515feeaf75da0a3e403aa70fb19dace001f952 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13693)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org