You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/10/05 19:58:11 UTC

[GitHub] [trafficserver] maskit commented on a diff in pull request #9114: Add event loop timing histogram data.

maskit commented on code in PR #9114:
URL: https://github.com/apache/trafficserver/pull/9114#discussion_r985331085


##########
include/tscpp/util/Histogram.h:
##########
@@ -0,0 +1,188 @@
+/** @file
+ *
+ * Fast small foot print histogram support.
+
+  @section license License
+
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+ */
+
+#pragma once
+
+#include <stdint.h>
+#include <array>
+
+#if !defined(TS_VERSION_NS)
+#define TS_VERSION_NS _10_0_0
+#endif
+
+namespace ts
+{
+inline namespace TS_VERSION_NS

Review Comment:
   Why do we need versioning for this but not others?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org