You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/23 01:11:55 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8636:
[dashboard scoped filters] Add all time related options to filters
initialization
codecov-io edited a comment on issue #8636: [dashboard scoped filters] Add all time related options to filters initialization
URL: https://github.com/apache/incubator-superset/pull/8636#issuecomment-557749648
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8636?src=pr&el=h1) Report
> Merging [#8636](https://codecov.io/gh/apache/incubator-superset/pull/8636?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6c83c6464a246f3c658483639044144e24bbe21a?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `26.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8636?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8636 +/- ##
==========================================
- Coverage 65.78% 65.71% -0.07%
==========================================
Files 482 482
Lines 23814 23824 +10
Branches 2589 2594 +5
==========================================
- Hits 15667 15657 -10
- Misses 7978 7994 +16
- Partials 169 173 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8636?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../assets/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8636/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9GaWx0ZXJCb3gvRmlsdGVyQm94LmpzeA==) | `5.93% <100%> (ø)` | :arrow_up: |
| [...ssets/src/dashboard/util/activeDashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8636/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9hY3RpdmVEYXNoYm9hcmRGaWx0ZXJzLmpz) | `90.38% <50%> (-1.78%)` | :arrow_down: |
| [...src/dashboard/util/getFilterConfigsFromFormdata.js](https://codecov.io/gh/apache/incubator-superset/pull/8636/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRGaWx0ZXJDb25maWdzRnJvbUZvcm1kYXRhLmpz) | `42.85% <9.09%> (-32.15%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8636/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `55.55% <0%> (-27.78%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8636?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8636?src=pr&el=footer). Last update [6c83c64...2b3f1a3](https://codecov.io/gh/apache/incubator-superset/pull/8636?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org