[GitHub] [hadoop] dannycjones commented on a change in pull request #3927: HADOOP-15245. S3AInputStream.skip() to use lazy seek

[GitBox <gi...@apache.org>]

dannycjones commented on a change in pull request #3927:
URL: https://github.com/apache/hadoop/pull/3927#discussion_r814094303



##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/statistics/impl/EmptyS3AStatisticsContext.java
##########
@@ -317,6 +322,9 @@ public long getInputPolicy() {
       return 0;
     }
 
+    @Override
+    public long getSkipOperations() { return 0; }

Review comment:
       This line introduces a new checkstyle violation, can you drop the return on to a new line?
   
   ```
   ./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/statistics/impl/EmptyS3AStatisticsContext.java:326:    public long getSkipOperations() { return 0; }:37: '{' at column 37 should have line break after. [LeftCurly]
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org