You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/01 07:20:01 UTC
[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new pull request
#1662: fix 0% UT coverage on new code. issue #1611
Jave-Chen opened a new pull request #1662: fix 0% UT coverage on new code. issue #1611
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1662
## What is the purpose of the pull request
Fix SonarCloud 0% UT coverage on new code. issue #1611
## Brief change log
Changes with maven command :
1. Remove org.jacoco:jacoco-maven-plugin:prepare-agent .
2. Replace org.sonarsource.scanner.maven:sonar-maven-plugin:sonar to org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.1.1688:sonar .
## Verify this pull request
Report at https://sonarcloud.io/dashboard?id=dolphinscheduler with 13.5% coverage .
![](https://user-images.githubusercontent.com/22913838/71639053-1d8c0700-2caa-11ea-8bc5-96041f2efa13.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1662:
fix 0% UT coverage on new code. issue #1611
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1662: fix 0% UT coverage on new code. issue #1611
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1662#issuecomment-570038326
resolve issue #1661
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong closed pull request #1662:
fix 0% UT coverage on new code. issue #1611
Posted by GitBox <gi...@apache.org>.
dailidong closed pull request #1662: fix 0% UT coverage on new code. issue #1611
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1662
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1662: fix 0% UT coverage on new code. issue #1611
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1662: fix 0% UT coverage on new code. issue #1611
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1662#issuecomment-570052971
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`dev@b471119`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1662 +/- ##
======================================
Coverage ? 14.92%
======================================
Files ? 284
Lines ? 13960
Branches ? 2270
======================================
Hits ? 2083
Misses ? 11655
Partials ? 222
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=footer). Last update [b471119...4b9ad18](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new pull request
#1662: fix 0% UT coverage on new code. issue #1611
Posted by GitBox <gi...@apache.org>.
Jave-Chen opened a new pull request #1662: fix 0% UT coverage on new code. issue #1611
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1662
## What is the purpose of the pull request
Fix SonarCloud 0% UT coverage on new code. issue #1611
## Brief change log
Changes with maven command :
1. Remove org.jacoco:jacoco-maven-plugin:prepare-agent .
2. Replace org.sonarsource.scanner.maven:sonar-maven-plugin:sonar to org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.1.1688:sonar .
## Verify this pull request
Report at https://sonarcloud.io/dashboard?id=dolphinscheduler with 13.5% coverage .
![](https://user-images.githubusercontent.com/22913838/71639053-1d8c0700-2caa-11ea-8bc5-96041f2efa13.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #1662:
fix 0% UT coverage on new code. issue #1611
Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #1662: fix 0% UT coverage on new code. issue #1611
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1662
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1662:
fix 0% UT coverage on new code. issue #1611
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1662: fix 0% UT coverage on new code. issue #1611
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1662#issuecomment-570052971
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`dev@b471119`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1662 +/- ##
======================================
Coverage ? 14.92%
======================================
Files ? 284
Lines ? 13960
Branches ? 2270
======================================
Hits ? 2083
Misses ? 11655
Partials ? 222
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=footer). Last update [b471119...4b9ad18](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1662?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services