[jira] [Commented] (FALCON-484) Refactor workflow related code into context, listener and Notification

["Venkatesh Seetharam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FALCON-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048809#comment-14048809 ] 

Venkatesh Seetharam commented on FALCON-484:
--------------------------------------------

Thanks [~shaik.idris] for taking time to review. 

bq. Is the Instrumentation being taken care? the aspect plugin requires some refactoring.
There has not been any change in this regard. The rename of class is taken care of.

bq. Can WorkflowExecutionContext.serialize() catch IOexception and simply wrap FalconException?
Well, does this matter since FalconPostProcessing throws exception.

bq. If all WorkflowExecutionContext args used for generating Options, then its better to simply iterate over args
Good idea. But not all is used. org.apache.falcon.workflow.WorkflowExecutionArgs#CONTEXT_FILE nor org.apache.falcon.workflow.WorkflowExecutionArgs#CONTEXT_TYPE are not used. However will change this.

> Refactor workflow related code into context, listener and Notification
> ----------------------------------------------------------------------
>
>                 Key: FALCON-484
>                 URL: https://issues.apache.org/jira/browse/FALCON-484
>             Project: Falcon
>          Issue Type: Sub-task
>          Components: messaging
>    Affects Versions: 0.6
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: refactoring
>             Fix For: 0.6
>
>         Attachments: FALCON-484.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)