You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/25 07:15:29 UTC
[GitHub] [hadoop-ozone] flirmnave opened a new pull request #601: HDDS-2816.
Fix shell description for --start parameter of listing keys
flirmnave opened a new pull request #601: HDDS-2816. Fix shell description for --start parameter of listing keys
URL: https://github.com/apache/hadoop-ozone/pull/601
## What changes were proposed in this pull request?
Fix ozone shell description.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2816
## How was this patch tested?
Run on docker-compose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] flirmnave commented on issue #601: HDDS-2816. Fix
shell description for --start parameter of listing keys
Posted by GitBox <gi...@apache.org>.
flirmnave commented on issue #601: HDDS-2816. Fix shell description for --start parameter of listing keys
URL: https://github.com/apache/hadoop-ozone/pull/601#issuecomment-591788918
Thanks @adoroszlai for review, I I fixed it now,
and my Apache Jira ID is **flirmnave**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #601: HDDS-2816. Fix
shell description for --start parameter of listing keys
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #601: HDDS-2816. Fix shell description for --start parameter of listing keys
URL: https://github.com/apache/hadoop-ozone/pull/601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #601: HDDS-2816. Fix
shell description for --start parameter of listing keys
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #601: HDDS-2816. Fix shell description for --start parameter of listing keys
URL: https://github.com/apache/hadoop-ozone/pull/601#issuecomment-591913373
Thanks @flirmnave for the update.
Unit test error is not related, filed [HDDS-3089](https://issues.apache.org/jira/browse/HDDS-3089) for it.
```
2020-02-27T05:28:36.6849915Z [ERROR] Crashed tests:
2020-02-27T05:28:36.6850376Z [ERROR] org.apache.hadoop.hdds.scm.node.TestSCMNodeManager
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#601: HDDS-2816. Fix shell description for --start parameter of listing keys
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #601: HDDS-2816. Fix shell description for --start parameter of listing keys
URL: https://github.com/apache/hadoop-ozone/pull/601#discussion_r384407196
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/ListKeyHandler.java
##########
@@ -50,7 +50,8 @@
private int maxKeys;
@Option(names = {"--start", "-s"},
- description = "The first key to start the listing")
+ description = "The key to start the listing from. " +
Review comment:
To be consistent with `volume list` and `bucket list`, can you please replace the space between the two sentences with a newline?
```suggestion
description = "The key to start the listing from.\n" +
```
For reference:
https://github.com/apache/hadoop-ozone/blob/8f3a42f35826aa59ceb2748bf64dca51e548a1bb/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/volume/ListVolumeHandler.java#L53-L56
https://github.com/apache/hadoop-ozone/blob/8f3a42f35826aa59ceb2748bf64dca51e548a1bb/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/ListBucketHandler.java#L53-L56
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org