[GitHub] [incubator-yunikorn-core] kingamarton commented on pull request #245: [YUNIKORN-519] Cleanup placeholders when the app is Completed

[GitBox <gi...@apache.org>]

kingamarton commented on pull request #245:
URL: https://github.com/apache/incubator-yunikorn-core/pull/245#issuecomment-775234187


   > I think we need to check the behaviour for an application moving into Waiting and then Completed state. Waiting state can be entered in 3 cases:
   > 
   > 1. an ask is removed and nothing is pending (ask) or allocated (real and placeholders)
   > 2. an allocation is removed and nothing is pending (ask) or allocated (real and placeholders)
   > 3. all allocations are removed and nothing is pending (ask)
   > 
   > Completed is only entered when we time out from waiting. So I am not sure if this is a real issue or that this will be solved indirectly by the placeholder timeout in YUNIKORN-460
   
   @wilfred-s, according to the [design doc](https://docs.google.com/document/d/1YpLZLqYsp5IaeEdl_AU9wZ-f16CfaaoRhZdalDP4RCg/edit):  `An application enters the waiting state at the time that there are no active allocations (allocated resources > 0) and pending allocation asks (pending resources > 0). Placeholders are not considered active allocations.`
   This means that when we enter the waiting state we can still have some active placeholders, what we need to delete when the app is finished.
   
   I think the completed state handling and the placeholder timeout are two different use cases, however both of them will perform the same cleaning. I think if an application is already completed, there is no reason for waiting until the placeholder allocation times out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org