You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@iota.apache.org by phalodi <gi...@git.apache.org> on 2016/07/04 17:44:47 UTC

[GitHub] incubator-iota pull request #5: Iota 21

GitHub user phalodi opened a pull request:

    https://github.com/apache/incubator-iota/pull/5

    Iota 21

    Refactor the built to manage dependencies in more efficient way and add scalastyle plugin for code quality.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phalodi/incubator-iota IOTA-21

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-iota/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5
    
----
commit 890742a042523a4f221101be137bca62cf366f71
Author: sandy <ph...@gmail.com>
Date:   2016-07-04T17:22:17Z

    Refactor build of performer to manage depenpencies more properly

commit 6ebd137d433857bc4b2a62ac9c6c1c7667b4ad99
Author: sandy <ph...@gmail.com>
Date:   2016-07-04T17:43:13Z

    add scalastyle for code quality

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-iota issue #5: Iota 21

Posted by phalodi <gi...@git.apache.org>.

Github user phalodi commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    https://issues.apache.org/jira/browse/IOTA-21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-iota issue #5: [IOTA-21]

Posted by barbaragomes <gi...@git.apache.org>.

Github user barbaragomes commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    @phalodi PR has been tested and will be merged once you, please, submit the following modifications:
    
    1. `BuildSettings`: change `organization := "com.libit"` to `organization := "org.apache.iota"`
    2. Remove all reference to the fey project since this folder is not actually a SBT project, like for example `lazy val fey = Project(` and `aggregate = Seq(Stream, ZMQ,fey)`
    3. `PerformersBuild`: Remove `stream` and `zmq` from `mainClass := Some`
    
    I understand that some of the requested changes were part of the first SBT Build.scala but it would be nice if we could have all of them in the same PR since we are refactoring it =)
    
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-iota issue #5: [IOTA-21]

Posted by phalodi <gi...@git.apache.org>.

Github user phalodi commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    @barbaragomes i fix it and push you can review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-iota issue #5: [IOTA-21]

Posted by phalodi <gi...@git.apache.org>.

Github user phalodi commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    @barbaragomes thanks for the comment its should be compile time right?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-iota issue #5: [IOTA-21]

Posted by phalodi <gi...@git.apache.org>.

Github user phalodi commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    @barbaragomes I make changes and push it once review it and give comment if needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-iota issue #5: [IOTA-21]

Posted by phalodi <gi...@git.apache.org>.

Github user phalodi commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    @barbaragomes I remove fey setting from build settings and also add organization name to basic setting so every project have it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-iota issue #5: [IOTA-21]

Posted by barbaragomes <gi...@git.apache.org>.

Github user barbaragomes commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    Thanks @phalodi.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-iota issue #5: [IOTA-21]

Posted by barbaragomes <gi...@git.apache.org>.

Github user barbaragomes commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    Taking a quick look I found one issue:
    
    1. `val ZMQDependecies = provided(akka_actor, zmq, fey)` the `zmq` dependence should not be `provided`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-iota issue #5: Iota 21

Posted by Barbara Malta Gomes <ba...@gmail.com>.

Hi Sandeep,

Thanks for your contribution.
We will review it.

*Comments:*

In order to link the PR to the JIRA issue you must use the following
notation:

Create a PR where:
    Title: [IOTA-XX] Title in the issue
    Desc: link to the issue
Make sure you add the *[ ] *and *IOTA* is all uppercase =D

Please, use https://github.com/apache/incubator-iota/pull/3 as an example
for the next time.

We will be adding how to submit PRs to IOTA documentation.

Thanks,
Barbara

On Mon, Jul 4, 2016 at 10:47 AM, phalodi <gi...@git.apache.org> wrote:

> Github user phalodi commented on the issue:
>
>     https://github.com/apache/incubator-iota/pull/5
>
>     @barbaragomes can you once review it and give comment on PR
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---

[GitHub] incubator-iota issue #5: Iota 21

Posted by phalodi <gi...@git.apache.org>.

Github user phalodi commented on the issue:

    https://github.com/apache/incubator-iota/pull/5
  
    @barbaragomes can you once review it and give comment on PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---