You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by rb...@apache.org on 2013/02/22 01:54:50 UTC

svn commit: r1448873 - in /shindig/trunk/features/src: main/javascript/features/container.site.gadget/gadget_holder.js test/javascript/features/container/gadget_holder_test.js

Author: rbaxter85
Date: Fri Feb 22 00:54:50 2013
New Revision: 1448873

URL: http://svn.apache.org/r1448873
Log:
shindig-1835
Committed for Marshall Shi
gadget iframe accessibility fixes

Modified:
    shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
    shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js

Modified: shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js?rev=1448873&r1=1448872&r2=1448873&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js (original)
+++ shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js Fri Feb 22 00:54:50 2013
@@ -162,7 +162,7 @@ osapi.container.GadgetHolder.IFRAME_ID_P
  */
 osapi.container.GadgetHolder.prototype.doNormalIframeHtml_ = function() {
   var uri = this.getIframeUrl_();
-  this.el_.innerHTML = this.createIframeHtml(uri);
+  this.el_.innerHTML = this.createIframeHtml(uri, {title:this.site_.getTitle()});
 
   // Set up RPC channel.
   var iframeUri = shindig.uri(uri);

Modified: shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js?rev=1448873&r1=1448872&r2=1448873&view=diff
==============================================================================
--- shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js (original)
+++ shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js Fri Feb 22 00:54:50 2013
@@ -76,6 +76,7 @@ GadgetHolderTest.prototype.testRenderWit
   this.assertEquals('<iframe' +
       ' marginwidth="0"' +
       ' hspace="0"' +
+      ' title="default title"' +
       ' frameborder="0"' +
       ' scrolling="no"' +
       ' onload="window.__gadgetOnLoad(\'gadget.xml\', \'123\');"' +
@@ -118,6 +119,7 @@ GadgetHolderTest.prototype.testRenderWit
       ' marginwidth="0"' +
       ' hspace="0"' +
       ' height="111"' +
+      ' title="default title"' +
       ' frameborder="0"' +
       ' scrolling="no"' +
       ' onload="window.__gadgetOnLoad(\'gadget.xml\', \'123\');"' +